| Message ID | 20231025132428.723672-2-mripard@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/2] drm/tests: Remove slow tests | expand |
Hi Maxime, Wouldn't be nice to add to the TODO list an item regarding the deleted drm_mm tests? Something just to remember us to develop new tests for it in the future. Best Regards, - Maíra On 10/25/23 10:24, Maxime Ripard wrote: > Most of those suites are undocumented and aren't really clear about what > they are testing. Let's add a TODO entry as a future task to get started > into KUnit and DRM. > > Signed-off-by: Maxime Ripard <mripard@kernel.org> > --- > Documentation/gpu/todo.rst | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > index 03fe5d1247be..b62c7fa0c2bc 100644 > --- a/Documentation/gpu/todo.rst > +++ b/Documentation/gpu/todo.rst > @@ -621,6 +621,23 @@ Contact: Javier Martinez Canillas <javierm@redhat.com> > > Level: Intermediate > > +Clean up and document former selftests suites > +--------------------------------------------- > + > +Some KUnit test suites (drm_buddy, drm_cmdline_parser, drm_damage_helper, > +drm_format, drm_framebuffer, drm_dp_mst_helper, drm_mm, drm_plane_helper and > +drm_rect) are former selftests suites that have been converted over when KUnit > +was first introduced. > + > +These suites were fairly undocumented, and with different goals than what unit > +tests can be. Trying to identify what each test in these suites actually test > +for, whether that makes sense for a unit test, and either remove it if it > +doesn't or document it if it does would be of great help. > + > +Contact: Maxime Ripard <mripard@kernel.org> > + > +Level: Intermediate > + > Enable trinity for DRM > ---------------------- >
Hi Maira, On Wed, Oct 25, 2023 at 02:26:44PM -0300, Maira Canal wrote: > Hi Maxime, > > Wouldn't be nice to add to the TODO list an item regarding the deleted > drm_mm tests? Something just to remember us to develop new tests for it > in the future. I guess we could, but it's really not clear to me what these were testing in the first place. So the scope of the work would effectively be "increase our test coverage" which I believe is already covered by the todo task just above. Maxime > On 10/25/23 10:24, Maxime Ripard wrote: > > Most of those suites are undocumented and aren't really clear about what > > they are testing. Let's add a TODO entry as a future task to get started > > into KUnit and DRM. > > > > Signed-off-by: Maxime Ripard <mripard@kernel.org> > > --- > > Documentation/gpu/todo.rst | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > > index 03fe5d1247be..b62c7fa0c2bc 100644 > > --- a/Documentation/gpu/todo.rst > > +++ b/Documentation/gpu/todo.rst > > @@ -621,6 +621,23 @@ Contact: Javier Martinez Canillas <javierm@redhat.com> > > Level: Intermediate > > +Clean up and document former selftests suites > > +--------------------------------------------- > > + > > +Some KUnit test suites (drm_buddy, drm_cmdline_parser, drm_damage_helper, > > +drm_format, drm_framebuffer, drm_dp_mst_helper, drm_mm, drm_plane_helper and > > +drm_rect) are former selftests suites that have been converted over when KUnit > > +was first introduced. > > + > > +These suites were fairly undocumented, and with different goals than what unit > > +tests can be. Trying to identify what each test in these suites actually test > > +for, whether that makes sense for a unit test, and either remove it if it > > +doesn't or document it if it does would be of great help. > > + > > +Contact: Maxime Ripard <mripard@kernel.org> > > + > > +Level: Intermediate > > + > > Enable trinity for DRM > > ---------------------- >
diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index 03fe5d1247be..b62c7fa0c2bc 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -621,6 +621,23 @@ Contact: Javier Martinez Canillas <javierm@redhat.com> Level: Intermediate +Clean up and document former selftests suites +--------------------------------------------- + +Some KUnit test suites (drm_buddy, drm_cmdline_parser, drm_damage_helper, +drm_format, drm_framebuffer, drm_dp_mst_helper, drm_mm, drm_plane_helper and +drm_rect) are former selftests suites that have been converted over when KUnit +was first introduced. + +These suites were fairly undocumented, and with different goals than what unit +tests can be. Trying to identify what each test in these suites actually test +for, whether that makes sense for a unit test, and either remove it if it +doesn't or document it if it does would be of great help. + +Contact: Maxime Ripard <mripard@kernel.org> + +Level: Intermediate + Enable trinity for DRM ----------------------
Most of those suites are undocumented and aren't really clear about what they are testing. Let's add a TODO entry as a future task to get started into KUnit and DRM. Signed-off-by: Maxime Ripard <mripard@kernel.org> --- Documentation/gpu/todo.rst | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)