| Message ID | 20231025095110.2405281-1-alexander.stein@ew.tq-group.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 10d510abd096d620b9fda2dd3e0047c5efc4ad2b |
| Headers | show |
| Series | [v2,1/1] usb: dwc3: Fix default mode initialization | expand |
On Wed, Oct 25, 2023 at 11:51:10AM +0200, Alexander Stein wrote: > The default mode, configurable by DT, shall be set before usb role switch > driver is registered. Otherwise there is a race between default mode > and mode set by usb role switch driver. > > Fixes: 98ed256a4dbad ("usb: dwc3: Add support for role-switch-default-mode binding") > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > This is a different approach to [1] to fix the race upon dwc3 role > initialization. dwc3_set_mode() needs to be called in dwc3_setup_role_switch() > to ensure the mode is initialized. > The usb role switch driver probe might be delayed or defered for some unrelated > reason, leaving the dwc3 mode unitialized if dwc3_set_mode() is not called here. > > [1] https://lore.kernel.org/linux-usb/2176034.Icojqenx9y@steina-w/T/ > > drivers/usb/dwc3/drd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You have marked a patch with a "Fixes:" tag for a commit that is in an older released kernel, yet you do not have a cc: stable line in the signed-off-by area at all, which means that the patch will not be applied to any older kernel releases. To properly fix this, please follow the documented rules in the Documentation/process/stable-kernel-rules.rst file for how to resolve this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
On Wed, Oct 25, 2023, Alexander Stein wrote: > The default mode, configurable by DT, shall be set before usb role switch > driver is registered. Otherwise there is a race between default mode > and mode set by usb role switch driver. > > Fixes: 98ed256a4dbad ("usb: dwc3: Add support for role-switch-default-mode binding") > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > This is a different approach to [1] to fix the race upon dwc3 role > initialization. dwc3_set_mode() needs to be called in dwc3_setup_role_switch() > to ensure the mode is initialized. > The usb role switch driver probe might be delayed or defered for some unrelated > reason, leaving the dwc3 mode unitialized if dwc3_set_mode() is not called here. > > [1] https://urldefense.com/v3/__https://lore.kernel.org/linux-usb/2176034.Icojqenx9y@steina-w/T/__;!!A4F2R9G_pg!Zc8CHjnvYetlp6H8Sd2mY11RaHe8fPpI0U0qtNjnx7c3vPF7Gf82Icsdr8cZG6J6A7HbdZ95TWtLZD1Z7QIUYrWXO-POFclME57B$ > > drivers/usb/dwc3/drd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c > index 039bf241769af..57ddd2e43022e 100644 > --- a/drivers/usb/dwc3/drd.c > +++ b/drivers/usb/dwc3/drd.c > @@ -505,6 +505,7 @@ static int dwc3_setup_role_switch(struct dwc3 *dwc) > dwc->role_switch_default_mode = USB_DR_MODE_PERIPHERAL; > mode = DWC3_GCTL_PRTCAP_DEVICE; > } > + dwc3_set_mode(dwc, mode); > > dwc3_role_switch.fwnode = dev_fwnode(dwc->dev); > dwc3_role_switch.set = dwc3_usb_role_switch_set; > @@ -526,7 +527,6 @@ static int dwc3_setup_role_switch(struct dwc3 *dwc) > } > } > > - dwc3_set_mode(dwc, mode); > return 0; > } > #else > -- > 2.34.1 > This should Cc stable. Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com> Thanks, Thinh
diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c index 039bf241769af..57ddd2e43022e 100644 --- a/drivers/usb/dwc3/drd.c +++ b/drivers/usb/dwc3/drd.c @@ -505,6 +505,7 @@ static int dwc3_setup_role_switch(struct dwc3 *dwc) dwc->role_switch_default_mode = USB_DR_MODE_PERIPHERAL; mode = DWC3_GCTL_PRTCAP_DEVICE; } + dwc3_set_mode(dwc, mode); dwc3_role_switch.fwnode = dev_fwnode(dwc->dev); dwc3_role_switch.set = dwc3_usb_role_switch_set; @@ -526,7 +527,6 @@ static int dwc3_setup_role_switch(struct dwc3 *dwc) } } - dwc3_set_mode(dwc, mode); return 0; } #else
The default mode, configurable by DT, shall be set before usb role switch driver is registered. Otherwise there is a race between default mode and mode set by usb role switch driver. Fixes: 98ed256a4dbad ("usb: dwc3: Add support for role-switch-default-mode binding") Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- This is a different approach to [1] to fix the race upon dwc3 role initialization. dwc3_set_mode() needs to be called in dwc3_setup_role_switch() to ensure the mode is initialized. The usb role switch driver probe might be delayed or defered for some unrelated reason, leaving the dwc3 mode unitialized if dwc3_set_mode() is not called here. [1] https://lore.kernel.org/linux-usb/2176034.Icojqenx9y@steina-w/T/ drivers/usb/dwc3/drd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)