diff mbox series

[1/2] usb: host: xhci-plat: Add quirk-no-64-bit-support

Message ID 20231031044021.1162403-2-mnkumar@google.com (mailing list archive)
State Superseded
Headers show
Series Add a quirk in xhci-plat for parent nodes to specify no 64 bit support | expand

Commit Message

Naveen Kumar Oct. 31, 2023, 4:40 a.m. UTC 
From: Naveen Kumar M <mnkumar@google.com>

This patch exposes the existing quirk XHCI_NO_64BIT_SUPPORT so that dwc3
clients can also use this flag. Despite HCCPARAMS1 being set to 1 some
clients may not support 64 bit addressing.

Signed-off-by: Naveen Kumar M <mnkumar@google.com>
---
 drivers/usb/host/xhci-plat.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Naveen Kumar Nov. 1, 2023, 4:43 a.m. UTC | #1 
Adding the reviewers/maintainers I missed in the previous mail to this patch

On Tue, Oct 31, 2023 at 10:10 AM Naveen Kumar <mnkumar@google.com> wrote:
>
> From: Naveen Kumar M <mnkumar@google.com>
>
> This patch exposes the existing quirk XHCI_NO_64BIT_SUPPORT so that dwc3
> clients can also use this flag. Despite HCCPARAMS1 being set to 1 some
> clients may not support 64 bit addressing.
>
> Signed-off-by: Naveen Kumar M <mnkumar@google.com>
> ---
>  drivers/usb/host/xhci-plat.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index b93161374293..d5f37decb7da 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -249,6 +249,9 @@ int xhci_plat_probe(struct platform_device *pdev, struct device *sysdev, const s
>                 if (device_property_read_bool(tmpdev, "quirk-broken-port-ped"))
>                         xhci->quirks |= XHCI_BROKEN_PORT_PED;
>
> +               if (device_property_read_bool(tmpdev, "quirk-no-64-bit-support"))
> +                       xhci->quirks |= XHCI_NO_64BIT_SUPPORT;
> +
>                 device_property_read_u32(tmpdev, "imod-interval-ns",
>                                          &xhci->imod_interval);
>         }
> --
> 2.42.0.820.g83a721a137-goog
>
Greg KH Nov. 1, 2023, 6:27 a.m. UTC | #2 
On Wed, Nov 01, 2023 at 10:13:08AM +0530, Naveen Kumar M wrote:
> Adding the reviewers/maintainers I missed in the previous mail to this patch

That's not going to work, please resend a new series, and please, do not
top-post.

thanks,

greg k-h
diff mbox series

Patch

diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
index b93161374293..d5f37decb7da 100644
--- a/drivers/usb/host/xhci-plat.c
+++ b/drivers/usb/host/xhci-plat.c
@@ -249,6 +249,9 @@  int xhci_plat_probe(struct platform_device *pdev, struct device *sysdev, const s
 		if (device_property_read_bool(tmpdev, "quirk-broken-port-ped"))
 			xhci->quirks |= XHCI_BROKEN_PORT_PED;
 
+		if (device_property_read_bool(tmpdev, "quirk-no-64-bit-support"))
+			xhci->quirks |= XHCI_NO_64BIT_SUPPORT;
+
 		device_property_read_u32(tmpdev, "imod-interval-ns",
 					 &xhci->imod_interval);
 	}