[v3,2/6] system/dirtylimit: Drop the reduplicative check

Commit Message

Yong Huang Nov. 1, 2023, 2:04 p.m. UTC

Checking if dirty limit is in service is done by the
dirtylimit_query_all function, drop the reduplicative
check in the qmp_query_vcpu_dirty_limit function.

Signed-off-by: Hyman Huang <[e-mail]>
Reviewed-by: Fabiano Rosas <[e-mail]>
Message-Id: <31[e-mail]>
---
 system/dirtylimit.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Juan Quintela Nov. 2, 2023, 10:28 a.m. UTC | #1

Hyman Huang <[e-mail]> wrote:
> Checking if dirty limit is in service is done by the
> dirtylimit_query_all function, drop the reduplicative
> check in the qmp_query_vcpu_dirty_limit function.
>
> Signed-off-by: Hyman Huang <[e-mail]>
> Reviewed-by: Fabiano Rosas <[e-mail]>
> Message-Id: <31[e-mail]>

Reviewed-by: Juan Quintela <[e-mail]>
queued.

Patch

diff --git a/system/dirtylimit.c b/system/dirtylimit.c
index 3666c4cb7c..495c7a7082 100644
--- a/system/dirtylimit.c
+++ b/system/dirtylimit.c
@@ -652,10 +652,6 @@  static struct DirtyLimitInfoList *dirtylimit_query_all(void)
 
 struct DirtyLimitInfoList *qmp_query_vcpu_dirty_limit(Error **errp)
 {
-    if (!dirtylimit_in_service()) {
-        return NULL;
-    }
-
     return dirtylimit_query_all();
 }