| Message ID | 20231027174745.4058-1-anonolitunya@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/gt: Remove prohibited space after opening parenthesis | expand |
Hi Dorcas, On Fri, Oct 27, 2023 at 08:47:45PM +0300, Dorcas AnonoLitunya wrote: > Removes space after opening parenthesis. > > Fixes the checkpatch.pl error: > ERROR: space prohibited after that opening parenthesis '(' > > Signed-off-by: Dorcas AnonoLitunya <anonolitunya@gmail.com> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Thanks, Andi
Hi Dorcas, On Fri, Oct 27, 2023 at 08:47:45PM +0300, Dorcas AnonoLitunya wrote: > Removes space after opening parenthesis. > > Fixes the checkpatch.pl error: > ERROR: space prohibited after that opening parenthesis '(' > > Signed-off-by: Dorcas AnonoLitunya <anonolitunya@gmail.com> > --- > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c > index 4a11219e560e..40687806d22a 100644 > --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c > +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c > @@ -47,7 +47,7 @@ > #define GEN9_LR_CONTEXT_RENDER_SIZE (22 * PAGE_SIZE) > #define GEN11_LR_CONTEXT_RENDER_SIZE (14 * PAGE_SIZE) > > -#define GEN8_LR_CONTEXT_OTHER_SIZE ( 2 * PAGE_SIZE) > +#define GEN8_LR_CONTEXT_OTHER_SIZE (2 * PAGE_SIZE) I'm actually having second thoughts on this change. The space was left on purpose in order to be aligned with the defines above. On the other hand, this is a bit detached from the others and this change makes checkpatch happy. This is one of those patches that are not right and not wrong either. I'll give it a bit more time and merge if no complains arise. Andi > #define MAX_MMIO_BASES 3 > struct engine_info { > -- > 2.42.0.345.gaab89be2eb
On 30/10/2023 21:42, Andi Shyti wrote: > Hi Dorcas, > > On Fri, Oct 27, 2023 at 08:47:45PM +0300, Dorcas AnonoLitunya wrote: >> Removes space after opening parenthesis. >> >> Fixes the checkpatch.pl error: >> ERROR: space prohibited after that opening parenthesis '(' >> >> Signed-off-by: Dorcas AnonoLitunya <anonolitunya@gmail.com> >> --- >> drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c >> index 4a11219e560e..40687806d22a 100644 >> --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c >> +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c >> @@ -47,7 +47,7 @@ >> #define GEN9_LR_CONTEXT_RENDER_SIZE (22 * PAGE_SIZE) >> #define GEN11_LR_CONTEXT_RENDER_SIZE (14 * PAGE_SIZE) >> >> -#define GEN8_LR_CONTEXT_OTHER_SIZE ( 2 * PAGE_SIZE) >> +#define GEN8_LR_CONTEXT_OTHER_SIZE (2 * PAGE_SIZE) > I'm actually having second thoughts on this change. The space was > left on purpose in order to be aligned with the defines above. > > On the other hand, this is a bit detached from the others and > this change makes checkpatch happy. > > This is one of those patches that are not right and not wrong > either. > > I'll give it a bit more time and merge if no complains arise. > > Andi Hi Andi, No problem. I'll wait to observe as I look for another contribution to the project. Kind regards, Dorcas >> #define MAX_MMIO_BASES 3 >> struct engine_info { >> -- >> 2.42.0.345.gaab89be2eb
On Mon, 30 Oct 2023, Andi Shyti <andi.shyti@linux.intel.com> wrote: > Hi Dorcas, > > On Fri, Oct 27, 2023 at 08:47:45PM +0300, Dorcas AnonoLitunya wrote: >> Removes space after opening parenthesis. >> >> Fixes the checkpatch.pl error: >> ERROR: space prohibited after that opening parenthesis '(' >> >> Signed-off-by: Dorcas AnonoLitunya <anonolitunya@gmail.com> >> --- >> drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c >> index 4a11219e560e..40687806d22a 100644 >> --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c >> +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c >> @@ -47,7 +47,7 @@ >> #define GEN9_LR_CONTEXT_RENDER_SIZE (22 * PAGE_SIZE) >> #define GEN11_LR_CONTEXT_RENDER_SIZE (14 * PAGE_SIZE) >> >> -#define GEN8_LR_CONTEXT_OTHER_SIZE ( 2 * PAGE_SIZE) >> +#define GEN8_LR_CONTEXT_OTHER_SIZE (2 * PAGE_SIZE) > > I'm actually having second thoughts on this change. The space was > left on purpose in order to be aligned with the defines above. I'd merge the patch. BR, Jani. > > On the other hand, this is a bit detached from the others and > this change makes checkpatch happy. > > This is one of those patches that are not right and not wrong > either. > > I'll give it a bit more time and merge if no complains arise. > > Andi > >> #define MAX_MMIO_BASES 3 >> struct engine_info { >> -- >> 2.42.0.345.gaab89be2eb
Hi, On Thu, Nov 02, 2023 at 02:26:26PM +0200, Jani Nikula wrote: > On Mon, 30 Oct 2023, Andi Shyti <andi.shyti@linux.intel.com> wrote: > > Hi Dorcas, > > > > On Fri, Oct 27, 2023 at 08:47:45PM +0300, Dorcas AnonoLitunya wrote: > >> Removes space after opening parenthesis. > >> > >> Fixes the checkpatch.pl error: > >> ERROR: space prohibited after that opening parenthesis '(' > >> > >> Signed-off-by: Dorcas AnonoLitunya <anonolitunya@gmail.com> > >> --- > >> drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c > >> index 4a11219e560e..40687806d22a 100644 > >> --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c > >> +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c > >> @@ -47,7 +47,7 @@ > >> #define GEN9_LR_CONTEXT_RENDER_SIZE (22 * PAGE_SIZE) > >> #define GEN11_LR_CONTEXT_RENDER_SIZE (14 * PAGE_SIZE) > >> > >> -#define GEN8_LR_CONTEXT_OTHER_SIZE ( 2 * PAGE_SIZE) > >> +#define GEN8_LR_CONTEXT_OTHER_SIZE (2 * PAGE_SIZE) > > > > I'm actually having second thoughts on this change. The space was > > left on purpose in order to be aligned with the defines above. > > I'd merge the patch. thanks for your opinion! Merged in drm-intel-gt-next. Thanks, Andi
diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c index 4a11219e560e..40687806d22a 100644 --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c @@ -47,7 +47,7 @@ #define GEN9_LR_CONTEXT_RENDER_SIZE (22 * PAGE_SIZE) #define GEN11_LR_CONTEXT_RENDER_SIZE (14 * PAGE_SIZE) -#define GEN8_LR_CONTEXT_OTHER_SIZE ( 2 * PAGE_SIZE) +#define GEN8_LR_CONTEXT_OTHER_SIZE (2 * PAGE_SIZE) #define MAX_MMIO_BASES 3 struct engine_info {
Removes space after opening parenthesis. Fixes the checkpatch.pl error: ERROR: space prohibited after that opening parenthesis '(' Signed-off-by: Dorcas AnonoLitunya <anonolitunya@gmail.com> --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)