| Message ID | 20231102075113.1043358-1-nichen@iscas.ac.cn (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6437760accfbaf1160342adeaea1a73dcd278799 |
| Headers | show |
| Series | usb: misc: eud: Add IRQ check for platform_get_irq() | expand |
On 02/11/2023 07:51, Chen Ni wrote: > The function eud_probe() should check the return value of > platform_get_irq() for errors so as to not pass a negative value to > the devm_request_threaded_irq(). > > Signed-off-by: Chen Ni <nichen@iscas.ac.cn> Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org> > --- > drivers/usb/misc/qcom_eud.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/usb/misc/qcom_eud.c b/drivers/usb/misc/qcom_eud.c > index 7f371ea1248c..26e9b8749d8a 100644 > --- a/drivers/usb/misc/qcom_eud.c > +++ b/drivers/usb/misc/qcom_eud.c > @@ -205,6 +205,9 @@ static int eud_probe(struct platform_device *pdev) > return PTR_ERR(chip->mode_mgr); > > chip->irq = platform_get_irq(pdev, 0); > + if (chip->irq < 0) > + return chip->irq; > + > ret = devm_request_threaded_irq(&pdev->dev, chip->irq, handle_eud_irq, > handle_eud_irq_thread, IRQF_ONESHOT, NULL, chip); > if (ret)
diff --git a/drivers/usb/misc/qcom_eud.c b/drivers/usb/misc/qcom_eud.c index 7f371ea1248c..26e9b8749d8a 100644 --- a/drivers/usb/misc/qcom_eud.c +++ b/drivers/usb/misc/qcom_eud.c @@ -205,6 +205,9 @@ static int eud_probe(struct platform_device *pdev) return PTR_ERR(chip->mode_mgr); chip->irq = platform_get_irq(pdev, 0); + if (chip->irq < 0) + return chip->irq; + ret = devm_request_threaded_irq(&pdev->dev, chip->irq, handle_eud_irq, handle_eud_irq_thread, IRQF_ONESHOT, NULL, chip); if (ret)
The function eud_probe() should check the return value of platform_get_irq() for errors so as to not pass a negative value to the devm_request_threaded_irq(). Signed-off-by: Chen Ni <nichen@iscas.ac.cn> --- drivers/usb/misc/qcom_eud.c | 3 +++ 1 file changed, 3 insertions(+)