diff mbox series

[iproute2] ss: add support for rcv_wnd and rehash

Message ID 20231031111720.2871511-1-edumazet@google.com (mailing list archive)
State Accepted
Commit ef335508a8e533cba952e5667e4cd1b5eac5e26b
Delegated to: Stephen Hemminger
Headers show
Series [iproute2] ss: add support for rcv_wnd and rehash | expand

Checks

Context Check Description
netdev/tree_selection success Not a local patch

Commit Message

Eric Dumazet Oct. 31, 2023, 11:17 a.m. UTC
tcpi_rcv_wnd and tcpi_rehash were added in linux-6.2.

$ ss -ti
...
 cubic wscale:7,7 ... minrtt:0.01 snd_wnd:65536 rcv_wnd:458496

Signed-off-by: Eric Dumazet <edumazet@google.com>
---
 misc/ss.c | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Neal Cardwell Oct. 31, 2023, 12:08 p.m. UTC | #1
On Tue, Oct 31, 2023 at 7:17 AM Eric Dumazet <edumazet@google.com> wrote:
>
> tcpi_rcv_wnd and tcpi_rehash were added in linux-6.2.
>
> $ ss -ti
> ...
>  cubic wscale:7,7 ... minrtt:0.01 snd_wnd:65536 rcv_wnd:458496
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---

Thanks, Eric, for implementing this!

Acked-by: Neal Cardwell <ncardwell@google.com>

neal
patchwork-bot+netdevbpf@kernel.org Nov. 4, 2023, 1:10 a.m. UTC | #2
Hello:

This patch was applied to iproute2/iproute2.git (main)
by Stephen Hemminger <stephen@networkplumber.org>:

On Tue, 31 Oct 2023 11:17:20 +0000 you wrote:
> tcpi_rcv_wnd and tcpi_rehash were added in linux-6.2.
> 
> $ ss -ti
> ...
>  cubic wscale:7,7 ... minrtt:0.01 snd_wnd:65536 rcv_wnd:458496
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> 
> [...]

Here is the summary with links:
  - [iproute2] ss: add support for rcv_wnd and rehash
    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=ef335508a8e5

You are awesome, thank you!
diff mbox series

Patch

diff --git a/misc/ss.c b/misc/ss.c
index 2628c2e042f1cdb616ec8aa80d4f413b41dfd3f4..9438382b8e667529dc2cf4b020d8696a4175e992 100644
--- a/misc/ss.c
+++ b/misc/ss.c
@@ -865,6 +865,8 @@  struct tcpstat {
 	double		    min_rtt;
 	unsigned int 	    rcv_ooopack;
 	unsigned int	    snd_wnd;
+	unsigned int	    rcv_wnd;
+	unsigned int	    rehash;
 	int		    rcv_space;
 	unsigned int        rcv_ssthresh;
 	unsigned long long  busy_time;
@@ -2711,6 +2713,10 @@  static void tcp_stats_print(struct tcpstat *s)
 		out(" rcv_ooopack:%u", s->rcv_ooopack);
 	if (s->snd_wnd)
 		out(" snd_wnd:%u", s->snd_wnd);
+	if (s->rcv_wnd)
+		out(" rcv_wnd:%u", s->rcv_wnd);
+	if (s->rehash)
+		out(" rehash:%u", s->rehash);
 }
 
 static void tcp_timer_print(struct tcpstat *s)
@@ -3147,6 +3153,8 @@  static void tcp_show_info(const struct nlmsghdr *nlh, struct inet_diag_msg *r,
 		s.bytes_retrans = info->tcpi_bytes_retrans;
 		s.rcv_ooopack = info->tcpi_rcv_ooopack;
 		s.snd_wnd = info->tcpi_snd_wnd;
+		s.rcv_wnd = info->tcpi_rcv_wnd;
+		s.rehash = info->tcpi_rehash;
 		tcp_stats_print(&s);
 		free(s.dctcp);
 		free(s.bbr_info);