Message ID | 1699251565-28759-2-git-send-email-quic_zijuhu@quicinc.com (mailing list archive) |
---|---|
State | Superseded |
Headers | show |
Series | Bluetooth: Support SCO offload for QCA2066 | expand |
Context | Check | Description |
---|---|---|
tedd_an/pre-ci_am | success | Success |
tedd_an/CheckPatch | success | CheckPatch PASS |
tedd_an/GitLint | fail | WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 1: T1 Title exceeds max length (89>80): "[v1,1/2] Bluetooth: hci_conn: Check non NULL before calling hdev->get_codec_config_data()" |
tedd_an/SubjectPrefix | success | Gitlint PASS |
tedd_an/BuildKernel | success | BuildKernel PASS |
tedd_an/CheckAllWarning | success | CheckAllWarning PASS |
tedd_an/CheckSparse | success | CheckSparse PASS |
tedd_an/CheckSmatch | success | CheckSparse PASS |
tedd_an/BuildKernel32 | success | BuildKernel32 PASS |
tedd_an/TestRunnerSetup | success | TestRunnerSetup PASS |
tedd_an/TestRunner_l2cap-tester | success | TestRunner PASS |
tedd_an/TestRunner_iso-tester | success | TestRunner PASS |
tedd_an/TestRunner_bnep-tester | success | TestRunner PASS |
tedd_an/TestRunner_mgmt-tester | fail | TestRunner_mgmt-tester: Total: 497, Passed: 496 (99.8%), Failed: 1, Not Run: 0 |
tedd_an/TestRunner_rfcomm-tester | success | TestRunner PASS |
tedd_an/TestRunner_sco-tester | success | TestRunner PASS |
tedd_an/TestRunner_ioctl-tester | success | TestRunner PASS |
tedd_an/TestRunner_mesh-tester | success | TestRunner PASS |
tedd_an/TestRunner_smp-tester | success | TestRunner PASS |
tedd_an/TestRunner_userchan-tester | success | TestRunner PASS |
tedd_an/IncrementalBuild | success | Incremental Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=798985 ---Test result--- Test Summary: CheckPatch PASS 1.25 seconds GitLint FAIL 0.94 seconds SubjectPrefix PASS 0.25 seconds BuildKernel PASS 27.61 seconds CheckAllWarning PASS 30.20 seconds CheckSparse PASS 35.48 seconds CheckSmatch PASS 98.58 seconds BuildKernel32 PASS 29.28 seconds TestRunnerSetup PASS 427.69 seconds TestRunner_l2cap-tester PASS 23.08 seconds TestRunner_iso-tester PASS 46.62 seconds TestRunner_bnep-tester PASS 7.08 seconds TestRunner_mgmt-tester FAIL 180.03 seconds TestRunner_rfcomm-tester PASS 11.19 seconds TestRunner_sco-tester PASS 14.49 seconds TestRunner_ioctl-tester PASS 12.27 seconds TestRunner_mesh-tester PASS 8.76 seconds TestRunner_smp-tester PASS 9.78 seconds TestRunner_userchan-tester PASS 7.43 seconds IncrementalBuild PASS 31.31 seconds Details ############################## Test: GitLint - FAIL Desc: Run gitlint Output: [v1,1/2] Bluetooth: hci_conn: Check non NULL before calling hdev->get_codec_config_data() WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 1: T1 Title exceeds max length (89>80): "[v1,1/2] Bluetooth: hci_conn: Check non NULL before calling hdev->get_codec_config_data()" ############################## Test: TestRunner_mgmt-tester - FAIL Desc: Run mgmt-tester with test-runner Output: Total: 497, Passed: 496 (99.8%), Failed: 1, Not Run: 0 Failed Test Cases Pairing Acceptor - SMP over BR/EDR 2 Timed out 2.358 seconds --- Regards, Linux Bluetooth
diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c index 2cee330188ce..d647eb4606a7 100644 --- a/net/bluetooth/hci_conn.c +++ b/net/bluetooth/hci_conn.c @@ -346,7 +346,7 @@ static int hci_enhanced_setup_sync(struct hci_dev *hdev, void *data) bt_dev_dbg(hdev, "hcon %p", conn); /* for offload use case, codec needs to configured before opening SCO */ - if (conn->codec.data_path) + if (conn->codec.data_path && hdev->get_codec_config_data) configure_datapath_sync(hdev, &conn->codec); conn->state = BT_CONNECT;
Explicitly add non NULL checking before calling hdev->get_codec_config_data(). Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com> --- net/bluetooth/hci_conn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)