Message ID | 20231025031422.3695-1-jack.zhu@starfivetech.com (mailing list archive) |
---|---|
Headers | show |
Series | Add StarFive Camera Subsystem driver | expand |
On 2023/10/25 11:14, Jack Zhu wrote: > Hi, > > This series is the v11 series that attempts to support the Camera Subsystem > found on StarFive JH7110 SoC. Hi Hans and Laurent, Could you please help review the code? Thank you for your time!
On 2023/10/31 9:09, Jack Zhu wrote: > > > On 2023/10/25 11:14, Jack Zhu wrote: >> Hi, >> >> This series is the v11 series that attempts to support the Camera Subsystem >> found on StarFive JH7110 SoC. > > Hi Hans and Laurent, > > Could you please help review the code? > Thank you for your time! > Hi, Could you please take some time to help review the code? Thank you so much!
On Tue, Nov 07, 2023 at 11:27:27AM +0800, Jack Zhu wrote: > > > On 2023/10/31 9:09, Jack Zhu wrote: > > > > > > On 2023/10/25 11:14, Jack Zhu wrote: > >> Hi, > >> > >> This series is the v11 series that attempts to support the Camera Subsystem > >> found on StarFive JH7110 SoC. > > > > Hi Hans and Laurent, > > > > Could you please help review the code? > > Thank you for your time! > > > > Hi, > > Could you please take some time to help review the code? Thank you so much! It is the middle of the merge window, no new code can be added to any maintainers tree at this point in time, please relax there is no rush or deadline at all here. While you wait, why not help out and review other patch submissions from other developers, which will help your changes get to the top of the queue? That way everyone's load is reduced and you are not just asking for others to do work for you with nothing in return. thanks, greg k-h
On Tue, Nov 07, 2023 at 07:15:10AM +0100, Greg Kroah-Hartman wrote: > On Tue, Nov 07, 2023 at 11:27:27AM +0800, Jack Zhu wrote: > > > > > > On 2023/10/31 9:09, Jack Zhu wrote: > > > > > > > > > On 2023/10/25 11:14, Jack Zhu wrote: > > >> Hi, > > >> > > >> This series is the v11 series that attempts to support the Camera Subsystem > > >> found on StarFive JH7110 SoC. > > > > > > Hi Hans and Laurent, > > > > > > Could you please help review the code? > > > Thank you for your time! > > > > > > > Hi, > > > > Could you please take some time to help review the code? Thank you so much! > > It is the middle of the merge window, no new code can be added to any > maintainers tree at this point in time, please relax there is no rush or > deadline at all here. > > While you wait, why not help out and review other patch submissions from > other developers, which will help your changes get to the top of the > queue? That way everyone's load is reduced and you are not just asking > for others to do work for you with nothing in return. Also, while you wait, why not just finish off the last 3 items on the TODO list which would make your code not be required to go into the staging portion of the tree at all? You've had a few weeks now, what is preventing that from happening, and when will that work actually be done? thanks, greg k-h
On 2023/11/7 14:16, Greg Kroah-Hartman wrote: > On Tue, Nov 07, 2023 at 07:15:10AM +0100, Greg Kroah-Hartman wrote: >> On Tue, Nov 07, 2023 at 11:27:27AM +0800, Jack Zhu wrote: >> > >> > >> > On 2023/10/31 9:09, Jack Zhu wrote: >> > > >> > > >> > > On 2023/10/25 11:14, Jack Zhu wrote: >> > >> Hi, >> > >> >> > >> This series is the v11 series that attempts to support the Camera Subsystem >> > >> found on StarFive JH7110 SoC. >> > > >> > > Hi Hans and Laurent, >> > > >> > > Could you please help review the code? >> > > Thank you for your time! >> > > >> > >> > Hi, >> > >> > Could you please take some time to help review the code? Thank you so much! >> >> It is the middle of the merge window, no new code can be added to any >> maintainers tree at this point in time, please relax there is no rush or >> deadline at all here. >> >> While you wait, why not help out and review other patch submissions from >> other developers, which will help your changes get to the top of the >> queue? That way everyone's load is reduced and you are not just asking >> for others to do work for you with nothing in return. > Hi Greg, Thank you very much for your reply! I'm so sorry for sending emails too frequently in the past two weeks. I am willing to do something for the community. If you pay attention to my previous submission records, you will find that I have assisted other developers in modifying v4l2-compliance bugs. But I think currently I may not have enough ability to comprehensively review others' submissions. But I hope I can do something similar through learning later. Sincere thanks to everyone who commented. > Also, while you wait, why not just finish off the last 3 items on the > TODO list which would make your code not be required to go into the > staging portion of the tree at all? You've had a few weeks now, what is > preventing that from happening, and when will that work actually be > done? > One of my colleagues is doing related development, but he also has other projects at the same time, so he cannot devote all his efforts to this development. And we expect to use libcamera, which may take some time.
On Tue, Nov 07, 2023 at 04:05:11PM +0800, Jack Zhu wrote: > > Also, while you wait, why not just finish off the last 3 items on the > > TODO list which would make your code not be required to go into the > > staging portion of the tree at all? You've had a few weeks now, what is > > preventing that from happening, and when will that work actually be > > done? > > > > One of my colleagues is doing related development, but he also has other > projects at the same time, so he cannot devote all his efforts to this > development. And we expect to use libcamera, which may take some time. So that means there is no real plan at all to get this out of the staging directory? If so, why should we take it at all as obviously this means that the code is now abandoned? confused, greg k-h
On 2023/11/7 16:27, Greg Kroah-Hartman wrote: > On Tue, Nov 07, 2023 at 04:05:11PM +0800, Jack Zhu wrote: >> > Also, while you wait, why not just finish off the last 3 items on the >> > TODO list which would make your code not be required to go into the >> > staging portion of the tree at all? You've had a few weeks now, what is >> > preventing that from happening, and when will that work actually be >> > done? >> > >> >> One of my colleagues is doing related development, but he also has other >> projects at the same time, so he cannot devote all his efforts to this >> development. And we expect to use libcamera, which may take some time. > > So that means there is no real plan at all to get this out of the > staging directory? If so, why should we take it at all as obviously > this means that the code is now abandoned? > Hi Greg, It's not like that, we won't give up on this code. We just want to make development easier using incremental development. Our developers are already working on development, but I can't give you an accurate time. There should be a preliminary version in about 3 months.
Hi Greg, On Tue, Nov 07, 2023 at 09:27:34AM +0100, Greg Kroah-Hartman wrote: > On Tue, Nov 07, 2023 at 04:05:11PM +0800, Jack Zhu wrote: > > > Also, while you wait, why not just finish off the last 3 items on the > > > TODO list which would make your code not be required to go into the > > > staging portion of the tree at all? You've had a few weeks now, what is > > > preventing that from happening, and when will that work actually be > > > done? > > > > One of my colleagues is doing related development, but he also has other > > projects at the same time, so he cannot devote all his efforts to this > > development. And we expect to use libcamera, which may take some time. > > So that means there is no real plan at all to get this out of the > staging directory? If so, why should we take it at all as obviously > this means that the code is now abandoned? "Taking some time" doesn't necessarily mean "abandoned". I agree that more often that not we've seen code dumped in staging and left there unmaintained. Once bitten, twice shy (or as we say in French, a scalded cat fears cold water), but let's not necessarily assume the worst possible outcome :-) Of course, if StarFive wants to speed up development of the ISP support, both on the kernel side and libcamera side, I'm sure Kieran and I can help (possibly not very fast if it is only done in our spare time though, but that's a separate discussion).