diff mbox series

[8/8] soc: qcom: socinfo: Add PM8937 Power IC

Message ID 20231106-pm8937-v1-8-ec51d9eeec53@riseup.net (mailing list archive)
State Superseded
Headers show
Series Add PM8937 PMIC support | expand

Commit Message

Dang Huynh Nov. 6, 2023, 12:08 p.m. UTC
The PM8917 and PM8937 uses the same SUBTYPE ID.

The PM8937 is found in boards with MSM8917, MSM8937 and MSM8940
and APQ variants.

Signed-off-by: Dang Huynh <danct12@riseup.net>
---
 drivers/soc/qcom/socinfo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Konrad Dybcio Nov. 7, 2023, 9:30 p.m. UTC | #1
On 11/6/23 13:08, Dang Huynh wrote:
> The PM8917 and PM8937 uses the same SUBTYPE ID.
> 
> The PM8937 is found in boards with MSM8917, MSM8937 and MSM8940
> and APQ variants.
> 
> Signed-off-by: Dang Huynh <danct12@riseup.net>
> ---
Are they secretly the same thing? Do you know somebody with a PM8917-
equipped device to check that theory out?

Konrad
Dang Huynh Nov. 8, 2023, 5:38 a.m. UTC | #2
On Tuesday, November 7, 2023 9:30:34 PM UTC Konrad Dybcio wrote:
> On 11/6/23 13:08, Dang Huynh wrote:
> > The PM8917 and PM8937 uses the same SUBTYPE ID.
> > 
> > The PM8937 is found in boards with MSM8917, MSM8937 and MSM8940
> > and APQ variants.
> > 
> > Signed-off-by: Dang Huynh <danct12@riseup.net>
> > ---
> 
> Are they secretly the same thing? Do you know somebody with a PM8917-
> equipped device to check that theory out?
> 
> Konrad

I don't know anyone with a PM8917 device, but I did check with downstream 
source and all the reference to pm8917 are either not used in any dts or point 
towards pm8937.

Dang
Bjorn Andersson Nov. 9, 2023, 3:22 p.m. UTC | #3
On Tue, Nov 07, 2023 at 10:30:34PM +0100, Konrad Dybcio wrote:
> 
> 
> On 11/6/23 13:08, Dang Huynh wrote:
> > The PM8917 and PM8937 uses the same SUBTYPE ID.
> > 
> > The PM8937 is found in boards with MSM8917, MSM8937 and MSM8940
> > and APQ variants.
> > 
> > Signed-off-by: Dang Huynh <danct12@riseup.net>
> > ---
> Are they secretly the same thing? Do you know somebody with a PM8917-
> equipped device to check that theory out?
> 

PM8917 and PM8937 are not the same.

Regards,
Bjorn
diff mbox series

Patch

diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
index 51e05bec5bfc..37692fc1aefb 100644
--- a/drivers/soc/qcom/socinfo.c
+++ b/drivers/soc/qcom/socinfo.c
@@ -93,7 +93,7 @@  static const char *const pmic_models[] = {
 	[22] = "PM8821",
 	[23] = "PM8038",
 	[24] = "PM8005/PM8922",
-	[25] = "PM8917",
+	[25] = "PM8917/PM8937",
 	[26] = "PM660L",
 	[27] = "PM660",
 	[30] = "PM8150",