diff mbox series

dpp: fix removed dpp_reset in Stop()

Message ID 20231109172522.37912-1-prestwoj@gmail.com (mailing list archive)
State New
Headers show
Series dpp: fix removed dpp_reset in Stop() | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
prestwoj/iwd-alpine-ci-fetch success Fetch PR
prestwoj/iwd-ci-gitlint success GitLint
prestwoj/iwd-ci-fetch success Fetch PR
prestwoj/iwd-ci-makedistcheck success Make Distcheck
prestwoj/iwd-alpine-ci-makedistcheck success Make Distcheck
prestwoj/iwd-alpine-ci-incremental_build success Incremental build not run PASS
prestwoj/iwd-ci-incremental_build success Incremental build not run PASS
prestwoj/iwd-ci-build success Build - Configure
prestwoj/iwd-alpine-ci-build success Build - Configure
prestwoj/iwd-ci-makecheckvalgrind success Make Check w/Valgrind
prestwoj/iwd-ci-makecheck success Make Check
prestwoj/iwd-ci-clang success clang PASS
prestwoj/iwd-alpine-ci-makecheckvalgrind success Make Check w/Valgrind
prestwoj/iwd-alpine-ci-makecheck success Make Check
prestwoj/iwd-ci-testrunner fail test-runner - FAIL: testDPP

Commit Message

James Prestwood Nov. 9, 2023, 5:25 p.m. UTC 
It seems in my patch reordering both stop methods lost the actual
call to dpp_reset().
---
 src/dpp.c | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Denis Kenzior Nov. 10, 2023, 2:16 a.m. UTC | #1 
Hi James,

On 11/9/23 11:25, James Prestwood wrote:
> It seems in my patch reordering both stop methods lost the actual
> call to dpp_reset().

In the future, lets use the Fixes: tag for commits like this.

> ---
>   src/dpp.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 

Applied, thanks.

Regards,
-Denis
diff mbox series

Patch

diff --git a/src/dpp.c b/src/dpp.c
index a0c44eda..9501f3de 100644
--- a/src/dpp.c
+++ b/src/dpp.c
@@ -3961,9 +3961,13 @@  static struct l_dbus_message *dpp_dbus_stop(struct l_dbus *dbus,
 {
 	struct dpp_sm *dpp = user_data;
 
+	l_debug("");
+
 	if (dpp->interface != DPP_INTERFACE_DPP)
 		return dbus_error_not_found(message);
 
+	dpp_reset(dpp);
+
 	return l_dbus_message_new_method_return(message);
 }
 
@@ -4340,9 +4344,13 @@  static struct l_dbus_message *dpp_dbus_pkex_stop(struct l_dbus *dbus,
 {
 	struct dpp_sm *dpp = user_data;
 
+	l_debug("");
+
 	if (dpp->interface != DPP_INTERFACE_PKEX)
 		return dbus_error_not_found(message);
 
+	dpp_reset(dpp);
+
 	return l_dbus_message_new_method_return(message);
 }