| Message ID | 20231108125843.3806765-13-arnd@kernel.org (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | -Wmissing-prototype warning fixes | expand |
On Wed, Nov 8, 2023 at 8:02 AM Arnd Bergmann <arnd@kernel.org> wrote: > > From: Arnd Bergmann <arnd@arndb.de> > > The arch_jump_label_transform_static() function in csky was originally meant to > override the generic __weak function, but that got changed to an #ifndef check. > > This showed up as a missing-prototype warning: > arch/csky/kernel/jump_label.c:43:6: error: no previous prototype for 'arch_jump_label_transform_static' [-Werror=missing-prototypes] > > Change the method to use the new method of having a #define and a prototype > for the global function. > > Fixes: 7e6b9db27de9 ("jump_label: make initial NOP patching the special case") > Fixes: 4e8bb4ba5a55 ("csky: Add jump-label implementation") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > arch/csky/include/asm/jump_label.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/csky/include/asm/jump_label.h b/arch/csky/include/asm/jump_label.h > index d488ba6084bc..98a3f4b168bd 100644 > --- a/arch/csky/include/asm/jump_label.h > +++ b/arch/csky/include/asm/jump_label.h > @@ -43,5 +43,10 @@ static __always_inline bool arch_static_branch_jump(struct static_key *key, > return true; > } > > +enum jump_label_type; > +void arch_jump_label_transform_static(struct jump_entry *entry, > + enum jump_label_type type); > +#define arch_jump_label_transform_static arch_jump_label_transform_static > + > #endif /* __ASSEMBLY__ */ > #endif /* __ASM_CSKY_JUMP_LABEL_H */ > -- > 2.39.2 > > Thank you! Reviewed-by: Guo Ren <guoren@kernel.org>
diff --git a/arch/csky/include/asm/jump_label.h b/arch/csky/include/asm/jump_label.h index d488ba6084bc..98a3f4b168bd 100644 --- a/arch/csky/include/asm/jump_label.h +++ b/arch/csky/include/asm/jump_label.h @@ -43,5 +43,10 @@ static __always_inline bool arch_static_branch_jump(struct static_key *key, return true; } +enum jump_label_type; +void arch_jump_label_transform_static(struct jump_entry *entry, + enum jump_label_type type); +#define arch_jump_label_transform_static arch_jump_label_transform_static + #endif /* __ASSEMBLY__ */ #endif /* __ASM_CSKY_JUMP_LABEL_H */