diff mbox series

[RFC,ipsec-next,1/8] iptfs: config: add CONFIG_XFRM_IPTFS

Message ID 20231110113719.3055788-2-chopps@chopps.org (mailing list archive)
State RFC
Delegated to: Netdev Maintainers
Headers show
Series [RFC,ipsec-next,1/8] iptfs: config: add CONFIG_XFRM_IPTFS | expand

Checks

Context Check Description
netdev/series_format warning Series does not have a cover letter
netdev/tree_selection success Guessed tree name to be net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit fail Errors and warnings before: 1264 this patch: 13
netdev/cc_maintainers warning 4 maintainers not CCed: herbert@gondor.apana.org.au kuba@kernel.org pabeni@redhat.com edumazet@google.com
netdev/build_clang fail Errors and warnings before: 1166 this patch: 13
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn fail Errors and warnings before: 1294 this patch: 13
netdev/checkpatch warning WARNING: Missing commit description - Add an appropriate one WARNING: please write a help paragraph that fully describes the config symbol
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Christian Hopps Nov. 10, 2023, 11:37 a.m. UTC 
From: Christian Hopps <chopps@labn.net>

Signed-off-by: Christian Hopps <chopps@labn.net>
---
 net/xfrm/Kconfig  | 9 +++++++++
 net/xfrm/Makefile | 1 +
 2 files changed, 10 insertions(+)

Comments

Simon Horman Nov. 12, 2023, 9:57 a.m. UTC | #1 
On Fri, Nov 10, 2023 at 06:37:12AM -0500, Christian Hopps wrote:
> From: Christian Hopps <chopps@labn.net>
> 
> Signed-off-by: Christian Hopps <chopps@labn.net>

Hi Christian,

thanks for your patchset.
Some feedback from my side, I hope it is useful.

> ---
>  net/xfrm/Kconfig  | 9 +++++++++
>  net/xfrm/Makefile | 1 +
>  2 files changed, 10 insertions(+)
> 
> diff --git a/net/xfrm/Kconfig b/net/xfrm/Kconfig
> index 3adf31a83a79..d07852069e68 100644
> --- a/net/xfrm/Kconfig
> +++ b/net/xfrm/Kconfig
> @@ -134,6 +134,15 @@ config NET_KEY_MIGRATE
>  
>  	  If unsure, say N.
>  
> +config XFRM_IPTFS
> +	bool "IPsec IPTFS (RFC 9347) encapsulation support"
> +	depends on XFRM
> +	help
> +	  Information on the IPTFS encapsulation can be found
> +          in RFC 9347.

nit: the indentation of the above seems inconsistent

> +
> +          If unsure, say N.
> +
>  config XFRM_ESPINTCP
>  	bool
>  
> diff --git a/net/xfrm/Makefile b/net/xfrm/Makefile
> index cd47f88921f5..9b870a3274a7 100644
> --- a/net/xfrm/Makefile
> +++ b/net/xfrm/Makefile
> @@ -20,4 +20,5 @@ obj-$(CONFIG_XFRM_USER) += xfrm_user.o
>  obj-$(CONFIG_XFRM_USER_COMPAT) += xfrm_compat.o
>  obj-$(CONFIG_XFRM_IPCOMP) += xfrm_ipcomp.o
>  obj-$(CONFIG_XFRM_INTERFACE) += xfrm_interface.o
> +obj-$(CONFIG_XFRM_IPTFS) += xfrm_iptfs.o
>  obj-$(CONFIG_XFRM_ESPINTCP) += espintcp.o

Unfortunately, this breaks allmodconfig builds.

Please ensure that each patch survives an allyesconfig and an allmodconfig
build with W=1 set without new warnings or failures. [1].

I also recommend checking that no new sparse warnings are introduced.

[1] https://docs.kernel.org/process/maintainer-netdev.html#expected-level-of-testing
Christian Hopps Nov. 12, 2023, 11:29 a.m. UTC | #2 
Simon Horman <horms@kernel.org> writes:

> On Fri, Nov 10, 2023 at 06:37:12AM -0500, Christian Hopps wrote:
>> From: Christian Hopps <chopps@labn.net>
>>
>> Signed-off-by: Christian Hopps <chopps@labn.net>
>
> Hi Christian,
>
> thanks for your patchset.
> Some feedback from my side, I hope it is useful.
>
>> ---
>>  net/xfrm/Kconfig  | 9 +++++++++
>>  net/xfrm/Makefile | 1 +
>>  2 files changed, 10 insertions(+)
>>
>> diff --git a/net/xfrm/Kconfig b/net/xfrm/Kconfig
>> index 3adf31a83a79..d07852069e68 100644
>> --- a/net/xfrm/Kconfig
>> +++ b/net/xfrm/Kconfig
>> @@ -134,6 +134,15 @@ config NET_KEY_MIGRATE
>>
>>  	  If unsure, say N.
>>
>> +config XFRM_IPTFS
>> +	bool "IPsec IPTFS (RFC 9347) encapsulation support"
>> +	depends on XFRM
>> +	help
>> +	  Information on the IPTFS encapsulation can be found
>> +          in RFC 9347.
>
> nit: the indentation of the above seems inconsistent

Yes, a spaces vs tabs issue, thanks fixed.

>> +
>> +          If unsure, say N.
>> +
>>  config XFRM_ESPINTCP
>>  	bool
>>
>> diff --git a/net/xfrm/Makefile b/net/xfrm/Makefile
>> index cd47f88921f5..9b870a3274a7 100644
>> --- a/net/xfrm/Makefile
>> +++ b/net/xfrm/Makefile
>> @@ -20,4 +20,5 @@ obj-$(CONFIG_XFRM_USER) += xfrm_user.o
>>  obj-$(CONFIG_XFRM_USER_COMPAT) += xfrm_compat.o
>>  obj-$(CONFIG_XFRM_IPCOMP) += xfrm_ipcomp.o
>>  obj-$(CONFIG_XFRM_INTERFACE) += xfrm_interface.o
>> +obj-$(CONFIG_XFRM_IPTFS) += xfrm_iptfs.o
>>  obj-$(CONFIG_XFRM_ESPINTCP) += espintcp.o
>
> Unfortunately, this breaks allmodconfig builds.

I've moved it to where the file is added in the last commit, thanks.

> Please ensure that each patch survives an allyesconfig and an allmodconfig
> build with W=1 set without new warnings or failures. [1].
>
> I also recommend checking that no new sparse warnings are introduced.

Ok, thanks,
Chris.

>
> [1] https://docs.kernel.org/process/maintainer-netdev.html#expected-level-of-testing
Antony Antony Nov. 12, 2023, 7:49 p.m. UTC | #3 
On Fri, Nov 10, 2023 at 06:37:12AM -0500, Christian Hopps via Devel wrote:
> From: Christian Hopps <chopps@labn.net>
> 
> Signed-off-by: Christian Hopps <chopps@labn.net>
> ---
>  net/xfrm/Kconfig  | 9 +++++++++
>  net/xfrm/Makefile | 1 +
>  2 files changed, 10 insertions(+)
> 
> diff --git a/net/xfrm/Kconfig b/net/xfrm/Kconfig
> index 3adf31a83a79..d07852069e68 100644
> --- a/net/xfrm/Kconfig
> +++ b/net/xfrm/Kconfig
> @@ -134,6 +134,15 @@ config NET_KEY_MIGRATE
>  
>  	  If unsure, say N.
>  
> +config XFRM_IPTFS
> +	bool "IPsec IPTFS (RFC 9347) encapsulation support"

RFC use "IP-TFS"?  in the text use consistanly. 


> +	depends on XFRM
> +	help
> +	  Information on the IPTFS encapsulation can be found
> +          in RFC 9347.

Add details what is actually supported when enabling this options. RFC 9347 
has several combinations. Are all combinations supported?

> +
> +          If unsure, say N.
> +
>  config XFRM_ESPINTCP
>  	bool
>  
> diff --git a/net/xfrm/Makefile b/net/xfrm/Makefile
> index cd47f88921f5..9b870a3274a7 100644
> --- a/net/xfrm/Makefile
> +++ b/net/xfrm/Makefile
> @@ -20,4 +20,5 @@ obj-$(CONFIG_XFRM_USER) += xfrm_user.o
>  obj-$(CONFIG_XFRM_USER_COMPAT) += xfrm_compat.o
>  obj-$(CONFIG_XFRM_IPCOMP) += xfrm_ipcomp.o
>  obj-$(CONFIG_XFRM_INTERFACE) += xfrm_interface.o
> +obj-$(CONFIG_XFRM_IPTFS) += xfrm_iptfs.o
>  obj-$(CONFIG_XFRM_ESPINTCP) += espintcp.o
> -- 
> 2.42.0
> 
> -- 
> Devel mailing list
> Devel@linux-ipsec.org
> https://linux-ipsec.org/mailman/listinfo/devel
Christian Hopps Nov. 13, 2023, 2:31 a.m. UTC | #4 
Antony Antony <antony@phenome.org> writes:

> On Fri, Nov 10, 2023 at 06:37:12AM -0500, Christian Hopps via Devel wrote:
>> From: Christian Hopps <chopps@labn.net>
>>
>> Signed-off-by: Christian Hopps <chopps@labn.net>
>> ---
>>  net/xfrm/Kconfig  | 9 +++++++++
>>  net/xfrm/Makefile | 1 +
>>  2 files changed, 10 insertions(+)
>>
>> diff --git a/net/xfrm/Kconfig b/net/xfrm/Kconfig
>> index 3adf31a83a79..d07852069e68 100644
>> --- a/net/xfrm/Kconfig
>> +++ b/net/xfrm/Kconfig
>> @@ -134,6 +134,15 @@ config NET_KEY_MIGRATE
>>
>>  	  If unsure, say N.
>>
>> +config XFRM_IPTFS
>> +	bool "IPsec IPTFS (RFC 9347) encapsulation support"
>
> RFC use "IP-TFS"?  in the text use consistanly.

Ok.

>> +	depends on XFRM
>> +	help
>> +	  Information on the IPTFS encapsulation can be found
>> +          in RFC 9347.
>
> Add details what is actually supported when enabling this options. RFC 9347
> has several combinations. Are all combinations supported?

Done.

Thanks,
Chris.

>> +
>> +          If unsure, say N.
>> +
>>  config XFRM_ESPINTCP
>>  	bool
>>
>> diff --git a/net/xfrm/Makefile b/net/xfrm/Makefile
>> index cd47f88921f5..9b870a3274a7 100644
>> --- a/net/xfrm/Makefile
>> +++ b/net/xfrm/Makefile
>> @@ -20,4 +20,5 @@ obj-$(CONFIG_XFRM_USER) += xfrm_user.o
>>  obj-$(CONFIG_XFRM_USER_COMPAT) += xfrm_compat.o
>>  obj-$(CONFIG_XFRM_IPCOMP) += xfrm_ipcomp.o
>>  obj-$(CONFIG_XFRM_INTERFACE) += xfrm_interface.o
>> +obj-$(CONFIG_XFRM_IPTFS) += xfrm_iptfs.o
>>  obj-$(CONFIG_XFRM_ESPINTCP) += espintcp.o
>> --
>> 2.42.0
>>
>> --
>> Devel mailing list
>> Devel@linux-ipsec.org
>> https://linux-ipsec.org/mailman/listinfo/devel
diff mbox series

Patch

diff --git a/net/xfrm/Kconfig b/net/xfrm/Kconfig
index 3adf31a83a79..d07852069e68 100644
--- a/net/xfrm/Kconfig
+++ b/net/xfrm/Kconfig
@@ -134,6 +134,15 @@  config NET_KEY_MIGRATE
 
 	  If unsure, say N.
 
+config XFRM_IPTFS
+	bool "IPsec IPTFS (RFC 9347) encapsulation support"
+	depends on XFRM
+	help
+	  Information on the IPTFS encapsulation can be found
+          in RFC 9347.
+
+          If unsure, say N.
+
 config XFRM_ESPINTCP
 	bool
 
diff --git a/net/xfrm/Makefile b/net/xfrm/Makefile
index cd47f88921f5..9b870a3274a7 100644
--- a/net/xfrm/Makefile
+++ b/net/xfrm/Makefile
@@ -20,4 +20,5 @@  obj-$(CONFIG_XFRM_USER) += xfrm_user.o
 obj-$(CONFIG_XFRM_USER_COMPAT) += xfrm_compat.o
 obj-$(CONFIG_XFRM_IPCOMP) += xfrm_ipcomp.o
 obj-$(CONFIG_XFRM_INTERFACE) += xfrm_interface.o
+obj-$(CONFIG_XFRM_IPTFS) += xfrm_iptfs.o
 obj-$(CONFIG_XFRM_ESPINTCP) += espintcp.o