| Message ID | 20231113145921.30104-2-francesco@dolcini.it (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d0c930b745cafde8e7d25d0356c648bca669556a |
| Headers | show |
| Series | usb: misc: onboard-hub: add support for Microchip USB5744 | expand |
On Mon, Nov 13, 2023 at 03:59:20PM +0100, Francesco Dolcini wrote: > From: Stefan Eichenberger <stefan.eichenberger@toradex.com> > > The USB5744 has two power supplies one for 3V3 and one for 1V2. Add the > second supply to the USB5744 DT binding. > > Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com> > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > --- > .../devicetree/bindings/usb/microchip,usb5744.yaml | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml b/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml > index ff3a1707ef57..6d4cfd943f58 100644 > --- a/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml > +++ b/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml > @@ -36,7 +36,11 @@ properties: > > vdd-supply: > description: > - VDD power supply to the hub > + 3V3 power supply to the hub > + > + vdd2-supply: > + description: > + 1V2 power supply to the hub How about v1p2-supply? > > peer-hub: > $ref: /schemas/types.yaml#/definitions/phandle > @@ -62,6 +66,7 @@ allOf: > properties: > reset-gpios: false > vdd-supply: false > + vdd2-supply: false > peer-hub: false > i2c-bus: false > else: > -- > 2.25.1 >
Hello Conor, thanks for the review. On Mon, Nov 13, 2023 at 07:55:20PM +0000, Conor Dooley wrote: > On Mon, Nov 13, 2023 at 03:59:20PM +0100, Francesco Dolcini wrote: > > From: Stefan Eichenberger <stefan.eichenberger@toradex.com> > > > > The USB5744 has two power supplies one for 3V3 and one for 1V2. Add the > > second supply to the USB5744 DT binding. > > > > Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com> > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > > --- > > .../devicetree/bindings/usb/microchip,usb5744.yaml | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml b/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml > > index ff3a1707ef57..6d4cfd943f58 100644 > > --- a/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml > > +++ b/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml > > @@ -36,7 +36,11 @@ properties: > > > > vdd-supply: > > description: > > - VDD power supply to the hub > > + 3V3 power supply to the hub > > + > > + vdd2-supply: > > + description: > > + 1V2 power supply to the hub > > How about v1p2-supply? The reason for vdd2 is this /* * Use generic names, as the actual names might differ between hubs. If a new * hub requires more than the currently supported supplies, add a new one here. */ static const char * const supply_names[] = { "vdd", "vdd2", }; from drivers/usb/misc/onboard_usb_hub.c. Francesco
On Mon, Nov 13, 2023 at 09:08:10PM +0100, Francesco Dolcini wrote: > Hello Conor, > thanks for the review. > > On Mon, Nov 13, 2023 at 07:55:20PM +0000, Conor Dooley wrote: > > On Mon, Nov 13, 2023 at 03:59:20PM +0100, Francesco Dolcini wrote: > > > From: Stefan Eichenberger <stefan.eichenberger@toradex.com> > > > > > > The USB5744 has two power supplies one for 3V3 and one for 1V2. Add the > > > second supply to the USB5744 DT binding. > > > > > > Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com> > > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > > > --- > > > .../devicetree/bindings/usb/microchip,usb5744.yaml | 7 ++++++- > > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml b/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml > > > index ff3a1707ef57..6d4cfd943f58 100644 > > > --- a/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml > > > +++ b/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml > > > @@ -36,7 +36,11 @@ properties: > > > > > > vdd-supply: > > > description: > > > - VDD power supply to the hub > > > + 3V3 power supply to the hub > > > + > > > + vdd2-supply: > > > + description: > > > + 1V2 power supply to the hub > > > > How about v1p2-supply? > > The reason for vdd2 is this I see. Acked-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor.
diff --git a/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml b/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml index ff3a1707ef57..6d4cfd943f58 100644 --- a/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml +++ b/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml @@ -36,7 +36,11 @@ properties: vdd-supply: description: - VDD power supply to the hub + 3V3 power supply to the hub + + vdd2-supply: + description: + 1V2 power supply to the hub peer-hub: $ref: /schemas/types.yaml#/definitions/phandle @@ -62,6 +66,7 @@ allOf: properties: reset-gpios: false vdd-supply: false + vdd2-supply: false peer-hub: false i2c-bus: false else: