| Message ID | 20231114072531.1366753-1-wentong.wu@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 30ce1c03a083c9dc131d09d28ba1bcaafa3d8df2 |
| Headers | show |
| Series | usb: misc: ljca: Drop _ADR support to get ljca children devices | expand |
Hi, On 11/14/23 08:25, Wentong Wu wrote: > Currently the shipped platforms use only _HID to distinguish > ljca children devices. The _ADR support here is for future HW. > This patch is to drop _ADR support and we can then re-introduce > it (revert this patch) if future HW actually starts using _ADR > to distinguish children devices. > > Signed-off-by: Wentong Wu <wentong.wu@intel.com> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/usb/misc/usb-ljca.c | 14 ++------------ > 1 file changed, 2 insertions(+), 12 deletions(-) > > diff --git a/drivers/usb/misc/usb-ljca.c b/drivers/usb/misc/usb-ljca.c > index c9decd0396d4..7f0deebebc13 100644 > --- a/drivers/usb/misc/usb-ljca.c > +++ b/drivers/usb/misc/usb-ljca.c > @@ -457,8 +457,8 @@ static void ljca_auxdev_acpi_bind(struct ljca_adapter *adap, > u64 adr, u8 id) > { > struct ljca_match_ids_walk_data wd = { 0 }; > - struct acpi_device *parent, *adev; > struct device *dev = adap->dev; > + struct acpi_device *parent; > char uid[4]; > > parent = ACPI_COMPANION(dev); > @@ -466,17 +466,7 @@ static void ljca_auxdev_acpi_bind(struct ljca_adapter *adap, > return; > > /* > - * get auxdev ACPI handle from the ACPI device directly > - * under the parent that matches _ADR. > - */ > - adev = acpi_find_child_device(parent, adr, false); > - if (adev) { > - ACPI_COMPANION_SET(&auxdev->dev, adev); > - return; > - } > - > - /* > - * _ADR is a grey area in the ACPI specification, some > + * Currently LJCA hw doesn't use _ADR instead the shipped > * platforms use _HID to distinguish children devices. > */ > switch (adr) {
On Tue, Nov 14, 2023 at 03:25:31PM +0800, Wentong Wu wrote: > Currently the shipped platforms use only _HID to distinguish > ljca children devices. The _ADR support here is for future HW. > This patch is to drop _ADR support and we can then re-introduce > it (revert this patch) if future HW actually starts using _ADR > to distinguish children devices. Thank you! Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
diff --git a/drivers/usb/misc/usb-ljca.c b/drivers/usb/misc/usb-ljca.c index c9decd0396d4..7f0deebebc13 100644 --- a/drivers/usb/misc/usb-ljca.c +++ b/drivers/usb/misc/usb-ljca.c @@ -457,8 +457,8 @@ static void ljca_auxdev_acpi_bind(struct ljca_adapter *adap, u64 adr, u8 id) { struct ljca_match_ids_walk_data wd = { 0 }; - struct acpi_device *parent, *adev; struct device *dev = adap->dev; + struct acpi_device *parent; char uid[4]; parent = ACPI_COMPANION(dev); @@ -466,17 +466,7 @@ static void ljca_auxdev_acpi_bind(struct ljca_adapter *adap, return; /* - * get auxdev ACPI handle from the ACPI device directly - * under the parent that matches _ADR. - */ - adev = acpi_find_child_device(parent, adr, false); - if (adev) { - ACPI_COMPANION_SET(&auxdev->dev, adev); - return; - } - - /* - * _ADR is a grey area in the ACPI specification, some + * Currently LJCA hw doesn't use _ADR instead the shipped * platforms use _HID to distinguish children devices. */ switch (adr) {
Currently the shipped platforms use only _HID to distinguish ljca children devices. The _ADR support here is for future HW. This patch is to drop _ADR support and we can then re-introduce it (revert this patch) if future HW actually starts using _ADR to distinguish children devices. Signed-off-by: Wentong Wu <wentong.wu@intel.com> --- drivers/usb/misc/usb-ljca.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-)