| Message ID | 20231106144335.v2.7.I1c8ab71570f6906fd020decb80675f05fbe1fe74@changeid (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/9] arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered | expand |
On Mon, Nov 06, 2023 at 02:43:34PM -0800, Douglas Anderson wrote: > As described in the patch ("arm64: dts: qcom: sc7180: Make watchdog > bark interrupt edge triggered"), the Qualcomm watchdog timer's bark > interrupt should be configured as edge triggered. Make the change. Please always make sure that the commit message is self-contained, and especially when you're referring to patch which has not yet been applied (e.g. consider someone doing git blame on this line some time down the road). Johan
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi index cad59af7ccef..b8081513176a 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi @@ -4225,7 +4225,7 @@ watchdog@17c10000 { compatible = "qcom,apss-wdt-sc8280xp", "qcom,kpss-wdt"; reg = <0 0x17c10000 0 0x1000>; clocks = <&sleep_clk>; - interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 0 IRQ_TYPE_EDGE_RISING>; }; timer@17c20000 {
As described in the patch ("arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered"), the Qualcomm watchdog timer's bark interrupt should be configured as edge triggered. Make the change. Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform") Reviewed-by: Guenter Roeck <linux@roeck-us.net> Reviewed-by: Stephen Boyd <swboyd@chromium.org> Signed-off-by: Douglas Anderson <dianders@chromium.org> --- (no changes since v1) arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)