| Message ID | 20231121142938.460846-1-nfraprado@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] drm/mediatek: dp: Add phy_mtk_dp module as pre-dependency | expand |
On Tue, 21 Nov 2023 15:29, "Nícolas F. R. A. Prado" <nfraprado@collabora.com> wrote: >The mtk_dp driver registers a phy device which is handled by the >phy_mtk_dp driver and assumes that the phy probe will complete >synchronously, proceeding to make use of functionality exposed by that >driver right away. This assumption however is false when the phy driver >is built as a module, causing the mtk_dp driver to fail probe in this >case. > >Add the phy_mtk_dp module as a pre-dependency to the mtk_dp module to >ensure the phy module has been loaded before the dp, so that the phy >probe happens synchrounously and the mtk_dp driver can probe >successfully even with the phy driver built as a module. > >Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort driver") >Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> >Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > >--- Reviewed-by: Guillaume Ranquet <granquet@baylibre.com> > >Changes in v2: >- Added missing Suggested-by tag > > drivers/gpu/drm/mediatek/mtk_dp.c | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/gpu/drm/mediatek/mtk_dp.c >index e4c16ba9902d..2136a596efa1 100644 >--- a/drivers/gpu/drm/mediatek/mtk_dp.c >+++ b/drivers/gpu/drm/mediatek/mtk_dp.c >@@ -2818,3 +2818,4 @@ MODULE_AUTHOR("Markus Schneider-Pargmann <msp@baylibre.com>"); > MODULE_AUTHOR("Bo-Chen Chen <rex-bc.chen@mediatek.com>"); > MODULE_DESCRIPTION("MediaTek DisplayPort Driver"); > MODULE_LICENSE("GPL"); >+MODULE_SOFTDEP("pre: phy_mtk_dp"); >-- >2.42.1 >
Hi, Nicolas: Nícolas F. R. A. Prado <nfraprado@collabora.com> 於 2023年11月21日 週二 下午10:29寫道： > > The mtk_dp driver registers a phy device which is handled by the > phy_mtk_dp driver and assumes that the phy probe will complete > synchronously, proceeding to make use of functionality exposed by that > driver right away. This assumption however is false when the phy driver > is built as a module, causing the mtk_dp driver to fail probe in this > case. > > Add the phy_mtk_dp module as a pre-dependency to the mtk_dp module to > ensure the phy module has been loaded before the dp, so that the phy > probe happens synchrounously and the mtk_dp driver can probe > successfully even with the phy driver built as a module. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort driver") > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > --- > > Changes in v2: > - Added missing Suggested-by tag > > drivers/gpu/drm/mediatek/mtk_dp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/gpu/drm/mediatek/mtk_dp.c > index e4c16ba9902d..2136a596efa1 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dp.c > +++ b/drivers/gpu/drm/mediatek/mtk_dp.c > @@ -2818,3 +2818,4 @@ MODULE_AUTHOR("Markus Schneider-Pargmann <msp@baylibre.com>"); > MODULE_AUTHOR("Bo-Chen Chen <rex-bc.chen@mediatek.com>"); > MODULE_DESCRIPTION("MediaTek DisplayPort Driver"); > MODULE_LICENSE("GPL"); > +MODULE_SOFTDEP("pre: phy_mtk_dp"); > -- > 2.42.1 >
diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/gpu/drm/mediatek/mtk_dp.c index e4c16ba9902d..2136a596efa1 100644 --- a/drivers/gpu/drm/mediatek/mtk_dp.c +++ b/drivers/gpu/drm/mediatek/mtk_dp.c @@ -2818,3 +2818,4 @@ MODULE_AUTHOR("Markus Schneider-Pargmann <msp@baylibre.com>"); MODULE_AUTHOR("Bo-Chen Chen <rex-bc.chen@mediatek.com>"); MODULE_DESCRIPTION("MediaTek DisplayPort Driver"); MODULE_LICENSE("GPL"); +MODULE_SOFTDEP("pre: phy_mtk_dp");
The mtk_dp driver registers a phy device which is handled by the phy_mtk_dp driver and assumes that the phy probe will complete synchronously, proceeding to make use of functionality exposed by that driver right away. This assumption however is false when the phy driver is built as a module, causing the mtk_dp driver to fail probe in this case. Add the phy_mtk_dp module as a pre-dependency to the mtk_dp module to ensure the phy module has been loaded before the dp, so that the phy probe happens synchrounously and the mtk_dp driver can probe successfully even with the phy driver built as a module. Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort driver") Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- Changes in v2: - Added missing Suggested-by tag drivers/gpu/drm/mediatek/mtk_dp.c | 1 + 1 file changed, 1 insertion(+)