mbox series

[0/8] btrfs: add a btrfs_chunk_map structure and preparatory cleanups

Message ID cover.1700573313.git.fdmanana@suse.com (mailing list archive)
Headers show
Series btrfs: add a btrfs_chunk_map structure and preparatory cleanups | expand

Message

Filipe Manana Nov. 21, 2023, 1:38 p.m. UTC
From: Filipe Manana <fdmanana@suse.com>

The following are some cleanups and introducing a dedicated data structure
for representing chunk maps, in order to make code simpler and use less
memory - this is achieved in patch 7/8. This patchset is also preparatory
work for some upcoming changes to extent maps.

Filipe Manana (8):
  btrfs: fix off-by-one when checking chunk map includes logical address
  btrfs: make error messages more clear when getting a chunk map
  btrfs: mark sanity checks when getting chunk map as unlikely
  btrfs: split assert into two different asserts when removing block group
  btrfs: unexport extent_map_block_end()
  btrfs: use btrfs_next_item() at scrub.c:find_first_extent_item()
  btrfs: use a dedicated data structure for chunk maps
  btrfs: remove stripe size local variable from insert_dev_extents()

 fs/btrfs/block-group.c            | 167 ++++-----
 fs/btrfs/block-group.h            |   6 +-
 fs/btrfs/dev-replace.c            |  28 +-
 fs/btrfs/disk-io.c                |   7 +-
 fs/btrfs/extent_map.c             |  53 +--
 fs/btrfs/extent_map.h             |  11 -
 fs/btrfs/fs.h                     |   3 +-
 fs/btrfs/inode.c                  |  25 +-
 fs/btrfs/raid56.h                 |   2 +-
 fs/btrfs/scrub.c                  |  52 ++-
 fs/btrfs/tests/btrfs-tests.c      |   3 +-
 fs/btrfs/tests/btrfs-tests.h      |   1 +
 fs/btrfs/tests/extent-map-tests.c |  40 +--
 fs/btrfs/volumes.c                | 545 ++++++++++++++++++------------
 fs/btrfs/volumes.h                |  45 ++-
 fs/btrfs/zoned.c                  |  24 +-
 include/trace/events/btrfs.h      |  11 +-
 17 files changed, 516 insertions(+), 507 deletions(-)

Comments

Josef Bacik Nov. 21, 2023, 2:12 p.m. UTC | #1
On Tue, Nov 21, 2023 at 01:38:31PM +0000, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> The following are some cleanups and introducing a dedicated data structure
> for representing chunk maps, in order to make code simpler and use less
> memory - this is achieved in patch 7/8. This patchset is also preparatory
> work for some upcoming changes to extent maps.
> 
> Filipe Manana (8):
>   btrfs: fix off-by-one when checking chunk map includes logical address
>   btrfs: make error messages more clear when getting a chunk map
>   btrfs: mark sanity checks when getting chunk map as unlikely
>   btrfs: split assert into two different asserts when removing block group
>   btrfs: unexport extent_map_block_end()
>   btrfs: use btrfs_next_item() at scrub.c:find_first_extent_item()
>   btrfs: use a dedicated data structure for chunk maps
>   btrfs: remove stripe size local variable from insert_dev_extents()
> 

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef
David Sterba Nov. 21, 2023, 9:03 p.m. UTC | #2
On Tue, Nov 21, 2023 at 01:38:31PM +0000, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> The following are some cleanups and introducing a dedicated data structure
> for representing chunk maps, in order to make code simpler and use less
> memory - this is achieved in patch 7/8. This patchset is also preparatory
> work for some upcoming changes to extent maps.
> 
> Filipe Manana (8):
>   btrfs: fix off-by-one when checking chunk map includes logical address
>   btrfs: make error messages more clear when getting a chunk map
>   btrfs: mark sanity checks when getting chunk map as unlikely
>   btrfs: split assert into two different asserts when removing block group
>   btrfs: unexport extent_map_block_end()
>   btrfs: use btrfs_next_item() at scrub.c:find_first_extent_item()
>   btrfs: use a dedicated data structure for chunk maps
>   btrfs: remove stripe size local variable from insert_dev_extents()

I have applied this to misc-next, withot the reordering in 7/8. This can
be done later eventually.