mbox series

[0/2] usb: fix port mapping for ZTE MF290 modem

Message ID 20231117231918.100278-1-lech.perczak@gmail.com (mailing list archive)
Headers show
Series usb: fix port mapping for ZTE MF290 modem | expand

Message

Lech Perczak Nov. 17, 2023, 11:19 p.m. UTC
This modem is used iside ZTE MF28D LTE CPE router. It can already
establish PPP connections. This series attempts to adjust its
configuration to properly support QMI interface which is available and
preferred over that. This is a part of effort to get the device
supported b OpenWrt.

Lech Perczak (2):
  usb: serial: option: don't claim interface 4 for ZTE MF290
  net: usb: qmi_wwan: claim interface 4 for ZTE MF290

 drivers/net/usb/qmi_wwan.c  | 1 +
 drivers/usb/serial/option.c | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)


base-commit: b85ea95d086471afb4ad062012a4d73cd328fa86

Comments

Paolo Abeni Nov. 21, 2023, 10:49 a.m. UTC | #1
On Sat, 2023-11-18 at 00:19 +0100, Lech Perczak wrote:
> This modem is used iside ZTE MF28D LTE CPE router. It can already
> establish PPP connections. This series attempts to adjust its
> configuration to properly support QMI interface which is available and
> preferred over that. This is a part of effort to get the device
> supported b OpenWrt.
> 
> Lech Perczak (2):
>   usb: serial: option: don't claim interface 4 for ZTE MF290
>   net: usb: qmi_wwan: claim interface 4 for ZTE MF290

It looks like patch 1 targets the usb-serial tree, patch 2 targets the
netdev tree and there no dependencies between them.

I think it would be cleaner if you re-submit the patches separately,
thanks!

Paolo
Paolo Abeni Nov. 21, 2023, 10:58 a.m. UTC | #2
On Tue, 2023-11-21 at 11:49 +0100, Paolo Abeni wrote:
> On Sat, 2023-11-18 at 00:19 +0100, Lech Perczak wrote:
> > This modem is used iside ZTE MF28D LTE CPE router. It can already
> > establish PPP connections. This series attempts to adjust its
> > configuration to properly support QMI interface which is available and
> > preferred over that. This is a part of effort to get the device
> > supported b OpenWrt.
> > 
> > Lech Perczak (2):
> >   usb: serial: option: don't claim interface 4 for ZTE MF290
> >   net: usb: qmi_wwan: claim interface 4 for ZTE MF290
> 
> It looks like patch 1 targets the usb-serial tree, patch 2 targets the
> netdev tree and there no dependencies between them.

Sorry, ENOCOFFEE here. I see the inter-dependency now. I guess it's
better to pull both patches via the same tree.

@Johan: do you have any preferences? We don't see changes on 
qmi_wwan.c too often, hopefully we should not hit conflicts up to the
next RC.

Cheers,

Paolo
Johan Hovold Nov. 21, 2023, 1:06 p.m. UTC | #3
On Tue, Nov 21, 2023 at 11:58:56AM +0100, Paolo Abeni wrote:
> On Tue, 2023-11-21 at 11:49 +0100, Paolo Abeni wrote:
> > On Sat, 2023-11-18 at 00:19 +0100, Lech Perczak wrote:
> > > This modem is used iside ZTE MF28D LTE CPE router. It can already
> > > establish PPP connections. This series attempts to adjust its
> > > configuration to properly support QMI interface which is available and
> > > preferred over that. This is a part of effort to get the device
> > > supported b OpenWrt.
> > > 
> > > Lech Perczak (2):
> > >   usb: serial: option: don't claim interface 4 for ZTE MF290
> > >   net: usb: qmi_wwan: claim interface 4 for ZTE MF290
> > 
> > It looks like patch 1 targets the usb-serial tree, patch 2 targets the
> > netdev tree and there no dependencies between them.
> 
> Sorry, ENOCOFFEE here. I see the inter-dependency now. I guess it's
> better to pull both patches via the same tree.
> 
> @Johan: do you have any preferences? We don't see changes on 
> qmi_wwan.c too often, hopefully we should not hit conflicts up to the
> next RC.

It should be fine to take these through the two trees, respectively, as
we usually do.

If the qmi_wwan change hits mainline first and that driver binds first,
all is good, otherwise option continues to bind until that patch is also
in mainline.

I'll go queue up the option patch now. Just let me know if you for some
reason prefer I take the qmi_wwan one too.

Johan
Paolo Abeni Nov. 23, 2023, 8:15 a.m. UTC | #4
On Tue, 2023-11-21 at 14:06 +0100, Johan Hovold wrote:
> On Tue, Nov 21, 2023 at 11:58:56AM +0100, Paolo Abeni wrote:
> > On Tue, 2023-11-21 at 11:49 +0100, Paolo Abeni wrote:
> > > On Sat, 2023-11-18 at 00:19 +0100, Lech Perczak wrote:
> > > > This modem is used iside ZTE MF28D LTE CPE router. It can already
> > > > establish PPP connections. This series attempts to adjust its
> > > > configuration to properly support QMI interface which is available and
> > > > preferred over that. This is a part of effort to get the device
> > > > supported b OpenWrt.
> > > > 
> > > > Lech Perczak (2):
> > > >   usb: serial: option: don't claim interface 4 for ZTE MF290
> > > >   net: usb: qmi_wwan: claim interface 4 for ZTE MF290
> > > 
> > > It looks like patch 1 targets the usb-serial tree, patch 2 targets the
> > > netdev tree and there no dependencies between them.
> > 
> > Sorry, ENOCOFFEE here. I see the inter-dependency now. I guess it's
> > better to pull both patches via the same tree.
> > 
> > @Johan: do you have any preferences? We don't see changes on 
> > qmi_wwan.c too often, hopefully we should not hit conflicts up to the
> > next RC.
> 
> It should be fine to take these through the two trees, respectively, as
> we usually do.

Fine by me: I'll take patch 2/2 only.

Cheers,

Paolo
patchwork-bot+netdevbpf@kernel.org Nov. 23, 2023, 9:20 a.m. UTC | #5
Hello:

This series was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Sat, 18 Nov 2023 00:19:16 +0100 you wrote:
> This modem is used iside ZTE MF28D LTE CPE router. It can already
> establish PPP connections. This series attempts to adjust its
> configuration to properly support QMI interface which is available and
> preferred over that. This is a part of effort to get the device
> supported b OpenWrt.
> 
> Lech Perczak (2):
>   usb: serial: option: don't claim interface 4 for ZTE MF290
>   net: usb: qmi_wwan: claim interface 4 for ZTE MF290
> 
> [...]

Here is the summary with links:
  - [1/2] usb: serial: option: don't claim interface 4 for ZTE MF290
    (no matching commit)
  - [2/2] net: usb: qmi_wwan: claim interface 4 for ZTE MF290
    https://git.kernel.org/netdev/net/c/99360d9620f0

You are awesome, thank you!