| Message ID | 20231123103808.17848-1-lukas.bulwahn@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9f0f0013d3d9395d535d91c623ecb0e82ce4c020 |
| Headers | show |
| Series | exynos-gsc: remove unused improper CONFIG definition | expand |
On 23/11/2023 11:38, Lukas Bulwahn wrote: > Defines prefixed with "CONFIG" should be limited to proper Kconfig options, > that are introduced in a Kconfig file. > > In the driver code, there is a define for CONFIG_VB2_GSC_DMA_CONTIG, but > this is not used anywhere in the code. > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/drivers/media/platform/samsung/exynos-gsc/gsc-core.h b/drivers/media/platform/samsung/exynos-gsc/gsc-core.h index 1ea5fa1bf3c8..b9777e07fb6d 100644 --- a/drivers/media/platform/samsung/exynos-gsc/gsc-core.h +++ b/drivers/media/platform/samsung/exynos-gsc/gsc-core.h @@ -26,7 +26,6 @@ #include "gsc-regs.h" -#define CONFIG_VB2_GSC_DMA_CONTIG 1 #define GSC_MODULE_NAME "exynos-gsc" #define GSC_SHUTDOWN_TIMEOUT ((100*HZ)/1000)
Defines prefixed with "CONFIG" should be limited to proper Kconfig options, that are introduced in a Kconfig file. In the driver code, there is a define for CONFIG_VB2_GSC_DMA_CONTIG, but this is not used anywhere in the code. Just remove this unused definition. No functional change. Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> --- drivers/media/platform/samsung/exynos-gsc/gsc-core.h | 1 - 1 file changed, 1 deletion(-)