| Message ID | 20231124185042.315148-1-schan@cloudflare.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | tools cpupower bench: Override CFLAGS assignments | expand |
Apologies, this is my first patch so I'm still learning.
Meant to add
Fixes: dbc4ca339c8d ("tools cpupower: Override CFLAGS assignments")
---
Stan
On 11/24/23 11:59, Stanley Chan wrote: > Apologies, this is my first patch so I'm still learning. > Meant to add > > Fixes: dbc4ca339c8d ("tools cpupower: Override CFLAGS assignments") > Thank you for the fix. Please send me v2 with this fixes tag. thanks, -- Shuah
diff --git a/tools/power/cpupower/bench/Makefile b/tools/power/cpupower/bench/Makefile index d9d9923af85c..a4b902f9e1c4 100644 --- a/tools/power/cpupower/bench/Makefile +++ b/tools/power/cpupower/bench/Makefile @@ -15,7 +15,7 @@ LIBS = -L../ -L$(OUTPUT) -lm -lcpupower OBJS = $(OUTPUT)main.o $(OUTPUT)parse.o $(OUTPUT)system.o $(OUTPUT)benchmark.o endif -CFLAGS += -D_GNU_SOURCE -I../lib -DDEFAULT_CONFIG_FILE=\"$(confdir)/cpufreq-bench.conf\" +override CFLAGS += -D_GNU_SOURCE -I../lib -DDEFAULT_CONFIG_FILE=\"$(confdir)/cpufreq-bench.conf\" $(OUTPUT)%.o : %.c $(ECHO) " CC " $@
Allow user to specify outside CFLAGS values as make argument Corrects an issue where CFLAGS is passed as a make argument for cpupower, but bench's makefile does not inherit and append to them. see also: commit dbc4ca339c8d ("tools cpupower: Override CFLAGS assignments") Signed-off-by: Stanley Chan <schan@cloudflare.com> --- tools/power/cpupower/bench/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)