diff mbox series

[v6,5/6] arm64: dts: qcom: sm4450-qrd: mark QRD4450 reserved gpios

Message ID 20231031075004.3850-6-quic_tengfan@quicinc.com (mailing list archive)
State Superseded
Headers show
Series soc: qcom: Add uart console support for SM4450 | expand

Commit Message

Tengfei Fan Oct. 31, 2023, 7:50 a.m. UTC
Some gpios are reserved for other subsystems, so mark these reserved
gpios.

Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sm4450-qrd.dts | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Konrad Dybcio Nov. 18, 2023, 12:45 a.m. UTC | #1
On 31.10.2023 08:50, Tengfei Fan wrote:
> Some gpios are reserved for other subsystems, so mark these reserved
> gpios.
> 
> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sm4450-qrd.dts | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm4450-qrd.dts b/arch/arm64/boot/dts/qcom/sm4450-qrd.dts
> index bb8c58fb4267..e354bad57a9e 100644
> --- a/arch/arm64/boot/dts/qcom/sm4450-qrd.dts
> +++ b/arch/arm64/boot/dts/qcom/sm4450-qrd.dts
> @@ -23,6 +23,11 @@
>  	status = "okay";
>  };
>  
> +&tlmm {
> +	/* Reserved for other subsystems */
that much we can guess :D

it would be very appreciated if you could do e.g.

<0 4>, /* fingerprint scanner */
<136 1>; /* coffee machine trigger */

Konrad
Tengfei Fan Nov. 27, 2023, 5:58 a.m. UTC | #2
在 11/18/2023 8:45 AM, Konrad Dybcio 写道:
> On 31.10.2023 08:50, Tengfei Fan wrote:
>> Some gpios are reserved for other subsystems, so mark these reserved
>> gpios.
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sm4450-qrd.dts | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm4450-qrd.dts b/arch/arm64/boot/dts/qcom/sm4450-qrd.dts
>> index bb8c58fb4267..e354bad57a9e 100644
>> --- a/arch/arm64/boot/dts/qcom/sm4450-qrd.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm4450-qrd.dts
>> @@ -23,6 +23,11 @@
>>   	status = "okay";
>>   };
>>   
>> +&tlmm {
>> +	/* Reserved for other subsystems */
> that much we can guess :D
> 
> it would be very appreciated if you could do e.g.
> 
> <0 4>, /* fingerprint scanner */
> <136 1>; /* coffee machine trigger */
> 
> Konrad
Hi Konrad,
Thank you for reviewing this patch series, I will update new patch 
series according to your suggestion.
Tengfei Fan Nov. 29, 2023, 10:44 a.m. UTC | #3
在 11/27/2023 1:58 PM, Tengfei Fan 写道:
> 
> 
> 在 11/18/2023 8:45 AM, Konrad Dybcio 写道:
>> On 31.10.2023 08:50, Tengfei Fan wrote:
>>> Some gpios are reserved for other subsystems, so mark these reserved
>>> gpios.
>>>
>>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>>> ---
>>>   arch/arm64/boot/dts/qcom/sm4450-qrd.dts | 5 +++++
>>>   1 file changed, 5 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sm4450-qrd.dts 
>>> b/arch/arm64/boot/dts/qcom/sm4450-qrd.dts
>>> index bb8c58fb4267..e354bad57a9e 100644
>>> --- a/arch/arm64/boot/dts/qcom/sm4450-qrd.dts
>>> +++ b/arch/arm64/boot/dts/qcom/sm4450-qrd.dts
>>> @@ -23,6 +23,11 @@
>>>       status = "okay";
>>>   };
>>> +&tlmm {
>>> +    /* Reserved for other subsystems */
>> that much we can guess :D
>>
>> it would be very appreciated if you could do e.g.
>>
>> <0 4>, /* fingerprint scanner */
>> <136 1>; /* coffee machine trigger */
>>
>> Konrad
> Hi Konrad,
> Thank you for reviewing this patch series, I will update new patch 
> series according to your suggestion.
Hi Konrad,
Storage team discovered that gpio 136 was inaccessible due to the 
pinctrl driver issue. So new version patch series will drop gpio 136 
from this gpio-reserved-ranges node.

New version patch series:
https://lore.kernel.org/linux-arm-msm/20231129103325.24854-1-quic_tengfan@quicinc.com/
> 
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sm4450-qrd.dts b/arch/arm64/boot/dts/qcom/sm4450-qrd.dts
index bb8c58fb4267..e354bad57a9e 100644
--- a/arch/arm64/boot/dts/qcom/sm4450-qrd.dts
+++ b/arch/arm64/boot/dts/qcom/sm4450-qrd.dts
@@ -23,6 +23,11 @@ 
 	status = "okay";
 };
 
+&tlmm {
+	/* Reserved for other subsystems */
+	gpio-reserved-ranges = <0 4>, <136 1>;
+};
+
 &uart7 {
 	status = "okay";
 };