mbox series

[0/8] nfsd fixes for 6.5.y

Message ID 170120874713.1515.13712791731008720729.stgit@klimt.1015granger.net (mailing list archive)
Headers show
Series nfsd fixes for 6.5.y | expand

Message

Chuck Lever Nov. 28, 2023, 9:59 p.m. UTC
Backport of upstream fixes to NFSD's duplicate reply cache. These 
have been hand-applied and tested with the same reproducer as was 
used to create the upstream fixes.

---

Chuck Lever (8):
      NFSD: Refactor nfsd_reply_cache_free_locked()
      NFSD: Rename nfsd_reply_cache_alloc()
      NFSD: Replace nfsd_prune_bucket()
      NFSD: Refactor the duplicate reply cache shrinker
      NFSD: Remove svc_rqst::rq_cacherep
      NFSD: Rename struct svc_cacherep
      NFSD: Fix "start of NFS reply" pointer passed to nfsd_cache_update()
      NFSD: Fix checksum mismatches in the duplicate reply cache


 fs/nfsd/cache.h            |   8 +-
 fs/nfsd/nfscache.c         | 266 ++++++++++++++++++++++++-------------
 fs/nfsd/nfssvc.c           |  20 ++-
 fs/nfsd/trace.h            |  26 +++-
 include/linux/sunrpc/svc.h |   1 -
 5 files changed, 218 insertions(+), 103 deletions(-)

--
Chuck Lever

Comments

Chuck Lever Nov. 28, 2023, 10:07 p.m. UTC | #1
> On Nov 28, 2023, at 4:59 PM, Chuck Lever <cel@kernel.org> wrote:
> 
> Backport of upstream fixes to NFSD's duplicate reply cache. These 
> have been hand-applied and tested with the same reproducer as was 
> used to create the upstream fixes.

After applying patches 1 through 6 cleanly, these applied with fuzz
and offset but no rejection -- the same as the 6.6.y patch set.
The context changes were due to Lorenzo's new nfsd netlink protocol.


> ---
> 
> Chuck Lever (8):
>      NFSD: Refactor nfsd_reply_cache_free_locked()
>      NFSD: Rename nfsd_reply_cache_alloc()
>      NFSD: Replace nfsd_prune_bucket()
>      NFSD: Refactor the duplicate reply cache shrinker
>      NFSD: Remove svc_rqst::rq_cacherep
>      NFSD: Rename struct svc_cacherep
>      NFSD: Fix "start of NFS reply" pointer passed to nfsd_cache_update()
>      NFSD: Fix checksum mismatches in the duplicate reply cache
> 
> 
> fs/nfsd/cache.h            |   8 +-
> fs/nfsd/nfscache.c         | 266 ++++++++++++++++++++++++-------------
> fs/nfsd/nfssvc.c           |  20 ++-
> fs/nfsd/trace.h            |  26 +++-
> include/linux/sunrpc/svc.h |   1 -
> 5 files changed, 218 insertions(+), 103 deletions(-)
> 
> --
> Chuck Lever
> 
> 

--
Chuck Lever
Greg KH Nov. 30, 2023, 1:25 p.m. UTC | #2
On Tue, Nov 28, 2023 at 10:07:11PM +0000, Chuck Lever III wrote:
> 
> 
> > On Nov 28, 2023, at 4:59 PM, Chuck Lever <cel@kernel.org> wrote:
> > 
> > Backport of upstream fixes to NFSD's duplicate reply cache. These 
> > have been hand-applied and tested with the same reproducer as was 
> > used to create the upstream fixes.
> 
> After applying patches 1 through 6 cleanly, these applied with fuzz
> and offset but no rejection -- the same as the 6.6.y patch set.
> The context changes were due to Lorenzo's new nfsd netlink protocol.

6.5.y is now end-of-life, sorry.

greg k-h
Chuck Lever Nov. 30, 2023, 1:49 p.m. UTC | #3
> On Nov 30, 2023, at 8:25 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> 
> On Tue, Nov 28, 2023 at 10:07:11PM +0000, Chuck Lever III wrote:
>> 
>> 
>>> On Nov 28, 2023, at 4:59 PM, Chuck Lever <cel@kernel.org> wrote:
>>> 
>>> Backport of upstream fixes to NFSD's duplicate reply cache. These 
>>> have been hand-applied and tested with the same reproducer as was 
>>> used to create the upstream fixes.
>> 
>> After applying patches 1 through 6 cleanly, these applied with fuzz
>> and offset but no rejection -- the same as the 6.6.y patch set.
>> The context changes were due to Lorenzo's new nfsd netlink protocol.
> 
> 6.5.y is now end-of-life, sorry.

Whoops, was it marked EOL a few days ago? I missed that.

No big deal, I just wanted to ensure all the stable kernels were covered.


--
Chuck Lever