| Message ID | 20231129100422.16659-2-quic_tengfan@quicinc.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | pinctrl: qcom: fix some sm4450 pinctrl issue | expand |
On 29.11.2023 11:04, Tengfei Fan wrote: > Use .remove_new() instead of .remove() for converting to plarform remove s/plarform/platform > callback returning void. > > Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> > --- The commit title should include the platform name, i.e. pinctrl: qcom: sm4450: xxx The change itself looks good Konrad
在 11/29/2023 9:21 PM, Konrad Dybcio 写道: > On 29.11.2023 11:04, Tengfei Fan wrote: >> Use .remove_new() instead of .remove() for converting to plarform remove > s/plarform/platform > >> callback returning void. >> >> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> >> --- > The commit title should include the platform name, i.e. > pinctrl: qcom: sm4450: xxx > > The change itself looks good > > Konrad Thanks Konrad review this patch, I will update patch as your comments.
diff --git a/drivers/pinctrl/qcom/pinctrl-sm4450.c b/drivers/pinctrl/qcom/pinctrl-sm4450.c index 20ad639087ed..49e2e3a7a9cb 100644 --- a/drivers/pinctrl/qcom/pinctrl-sm4450.c +++ b/drivers/pinctrl/qcom/pinctrl-sm4450.c @@ -993,7 +993,7 @@ static struct platform_driver sm4450_tlmm_driver = { .of_match_table = sm4450_tlmm_of_match, }, .probe = sm4450_tlmm_probe, - .remove = msm_pinctrl_remove, + .remove_new = msm_pinctrl_remove, }; MODULE_DEVICE_TABLE(of, sm4450_tlmm_of_match);
Use .remove_new() instead of .remove() for converting to plarform remove callback returning void. Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> --- drivers/pinctrl/qcom/pinctrl-sm4450.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)