| Message ID | 20231128194019.72762-1-bvanassche@acm.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | block: Document the role of the two attribute groups | expand |
On Tue, 28 Nov 2023 11:40:19 -0800, Bart Van Assche wrote: > It is nontrivial to derive the role of the two attribute groups in source > file block/blk-sysfs.c. Hence add a comment that explains their roles. See > also commit 6d85ebf95c44 ("blk-sysfs: add a new attr_group for blk_mq"). > > Applied, thanks! [1/1] block: Document the role of the two attribute groups commit: 3649ff0a0b152b5f00e8f56a5ce0da0945aae278 Best regards,
diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c index 63e481262336..0b2d04766324 100644 --- a/block/blk-sysfs.c +++ b/block/blk-sysfs.c @@ -615,6 +615,7 @@ static ssize_t queue_wb_lat_store(struct request_queue *q, const char *page, QUEUE_RW_ENTRY(queue_wb_lat, "wbt_lat_usec"); #endif +/* Common attributes for bio-based and request-based queues. */ static struct attribute *queue_attrs[] = { &queue_ra_entry.attr, &queue_max_hw_sectors_entry.attr, @@ -659,6 +660,7 @@ static struct attribute *queue_attrs[] = { NULL, }; +/* Request-based queue attributes that are not relevant for bio-based queues. */ static struct attribute *blk_mq_queue_attrs[] = { &queue_requests_entry.attr, &elv_iosched_entry.attr,
It is nontrivial to derive the role of the two attribute groups in source file block/blk-sysfs.c. Hence add a comment that explains their roles. See also commit 6d85ebf95c44 ("blk-sysfs: add a new attr_group for blk_mq"). Cc: Christoph Hellwig <hch@lst.de> Cc: Yu Kuai <yukuai3@huawei.com> Signed-off-by: Bart Van Assche <bvanassche@acm.org> --- block/blk-sysfs.c | 2 ++ 1 file changed, 2 insertions(+)