diff mbox series

[XEN,09/11] xen/param: address a violation of MISRA C:2012 Rule 8.2

Message ID 2ef34f3beec85dac126a89c6da1bbbdfaa00727d.1700832962.git.federico.serafini@bugseng.com (mailing list archive)
State Superseded
Headers show
Series xen: address violations of MISRA C:2012 Rule 8.2 | expand

Commit Message

Federico Serafini Nov. 24, 2023, 2:03 p.m. UTC 
Add missing parameter name. No functional change.

Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
---
 xen/include/xen/param.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jan Beulich Nov. 30, 2023, 4:29 p.m. UTC | #1 
On 24.11.2023 15:03, Federico Serafini wrote:
> Add missing parameter name. No functional change.
> 
> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>

Acked-by: Jan Beulich <jbeulich@suse.com>

> --- a/xen/include/xen/param.h
> +++ b/xen/include/xen/param.h
> @@ -22,7 +22,7 @@ struct kernel_param {
>      unsigned int len;
>      union {
>          void *var;
> -        int (*func)(const char *);
> +        int (*func)(const char *s);

Still I again wonder what good this name does us here.

Jan
Stefano Stabellini Dec. 1, 2023, 2:32 a.m. UTC | #2 
On Fri, 24 Nov 2023, Federico Serafini wrote:
> Add missing parameter name. No functional change.
> 
> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
diff mbox series

Patch

diff --git a/xen/include/xen/param.h b/xen/include/xen/param.h
index 93c3fe7cb7..9170455cde 100644
--- a/xen/include/xen/param.h
+++ b/xen/include/xen/param.h
@@ -22,7 +22,7 @@  struct kernel_param {
     unsigned int len;
     union {
         void *var;
-        int (*func)(const char *);
+        int (*func)(const char *s);
     } par;
 };