| Message ID | 20231201014101.15802-1-quic_parellan@quicinc.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Stabilize use of vblank_refcount | expand |
On Fri, 1 Dec 2023 at 03:41, Paloma Arellano <quic_parellan@quicinc.com> wrote: > > There is currently a race condition occuring when accessing > vblank_refcount. Therefore, vblank irq timeouts may occur. > > Avoid any vblank irq timeouts by stablizing the use of vblank_refcount. > > Changes from prior versions: > v2: - Slightly changed wording of patch #2 commit message > v3: - Mistakenly did not change wording of patch #2 in last version. > It is done now. Usually sending a series once a day is enough. If you have any pending changes, it might be better to reply to your patch stating that you want to do this and that, while still allowing reviewers to respond (and thus you can incorporate their review in the next iteration). > > Paloma Arellano (2): > drm/msm/dpu: Modify vblank_refcount if error in callback > drm/msm/dpu: Add mutex lock in control vblank irq > > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 6 ++++++ > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 6 ++++++ > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 11 +++++++++-- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 11 +++++++++-- > 4 files changed, 30 insertions(+), 4 deletions(-) > > -- > 2.41.0 >
On 11/30/2023 11:41 PM, Dmitry Baryshkov wrote: > On Fri, 1 Dec 2023 at 03:41, Paloma Arellano <quic_parellan@quicinc.com> wrote: >> There is currently a race condition occuring when accessing >> vblank_refcount. Therefore, vblank irq timeouts may occur. >> >> Avoid any vblank irq timeouts by stablizing the use of vblank_refcount. >> >> Changes from prior versions: >> v2: - Slightly changed wording of patch #2 commit message >> v3: - Mistakenly did not change wording of patch #2 in last version. >> It is done now. > Usually sending a series once a day is enough. If you have any pending > changes, it might be better to reply to your patch stating that you > want to do this and that, while still allowing reviewers to respond > (and thus you can incorporate their review in the next iteration). Ack. Good to know. Thank you, Paloma >> Paloma Arellano (2): >> drm/msm/dpu: Modify vblank_refcount if error in callback >> drm/msm/dpu: Add mutex lock in control vblank irq >> >> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 6 ++++++ >> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 6 ++++++ >> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 11 +++++++++-- >> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 11 +++++++++-- >> 4 files changed, 30 insertions(+), 4 deletions(-) >> >> -- >> 2.41.0 >> >
There is currently a race condition occuring when accessing vblank_refcount. Therefore, vblank irq timeouts may occur. Avoid any vblank irq timeouts by stablizing the use of vblank_refcount. Changes from prior versions: v2: - Slightly changed wording of patch #2 commit message v3: - Mistakenly did not change wording of patch #2 in last version. It is done now. Paloma Arellano (2): drm/msm/dpu: Modify vblank_refcount if error in callback drm/msm/dpu: Add mutex lock in control vblank irq drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 6 ++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 6 ++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 11 +++++++++-- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 11 +++++++++-- 4 files changed, 30 insertions(+), 4 deletions(-)