Message ID | 20231108153827.39692-2-davydov-max@yandex-team.ru (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | compare machine type compat_props | expand |
On 8/11/23 16:38, Maksim Davydov wrote: > qmp_qom_list_properties can print default values if they are available > as qmp_device_list_properties does, because both of them use the > ObjectPropertyInfo structure with default_value field. This can be useful > when working with "not device" types (e.g. memory-backend). > > Signed-off-by: Maksim Davydov <davydov-max@yandex-team.ru> > Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> > --- > qom/qom-qmp-cmds.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Maksim Davydov <davydov-max@yandex-team.ru> writes: > qmp_qom_list_properties can print default values if they are available > as qmp_device_list_properties does, because both of them use the > ObjectPropertyInfo structure with default_value field. This can be useful > when working with "not device" types (e.g. memory-backend). > > Signed-off-by: Maksim Davydov <davydov-max@yandex-team.ru> > Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> > --- > qom/qom-qmp-cmds.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/qom/qom-qmp-cmds.c b/qom/qom-qmp-cmds.c > index 7c087299de..e91a235347 100644 > --- a/qom/qom-qmp-cmds.c > +++ b/qom/qom-qmp-cmds.c > @@ -212,6 +212,7 @@ ObjectPropertyInfoList *qmp_qom_list_properties(const char *typename, > info->name = g_strdup(prop->name); > info->type = g_strdup(prop->type); > info->description = g_strdup(prop->description); > + info->default_value = qobject_ref(prop->defval); > > QAPI_LIST_PREPEND(prop_list, info); > } Reviewed-by: Markus Armbruster <armbru@redhat.com>
diff --git a/qom/qom-qmp-cmds.c b/qom/qom-qmp-cmds.c index 7c087299de..e91a235347 100644 --- a/qom/qom-qmp-cmds.c +++ b/qom/qom-qmp-cmds.c @@ -212,6 +212,7 @@ ObjectPropertyInfoList *qmp_qom_list_properties(const char *typename, info->name = g_strdup(prop->name); info->type = g_strdup(prop->type); info->description = g_strdup(prop->description); + info->default_value = qobject_ref(prop->defval); QAPI_LIST_PREPEND(prop_list, info); }