| Message ID | 20231201031505.286117-4-sxwjean@me.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | supplyment of slab allocator removal | expand |
On Fri, Dec 01, 2023 at 11:15:05AM +0800, sxwjean@me.com wrote: > From: Xiongwei Song <xiongwei.song@windriver.com> > > There is no a value assigned to slub_min_objects by default, it awlays ^^^^^^ > is 0 that is intailized by compiler if no assigned value by command line. ^^^^^^^^^^ > min_objects is calculated based on proccessor numbers in ^^^^^^^^^^ > calculate_order(). For more details, see commit 9b2cd506e5f2 ("slub: > Calculate min_objects based on number of processors.") nit: multiple spelling mistakes here. Please double-check commit logs with a spell checker. :) > > Signed-off-by: Xiongwei Song <xiongwei.song@windriver.com> > --- > Documentation/mm/slub.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/mm/slub.rst b/Documentation/mm/slub.rst > index be75971532f5..1f4399581449 100644 > --- a/Documentation/mm/slub.rst > +++ b/Documentation/mm/slub.rst > @@ -150,7 +150,7 @@ list_lock once in a while to deal with partial slabs. That overhead is > governed by the order of the allocation for each slab. The allocations > can be influenced by kernel parameters: > > -.. slub_min_objects=x (default 4) > +.. slub_min_objects=x (default 0) > .. slub_min_order=x (default 0) > .. slub_max_order=x (default 3 (PAGE_ALLOC_COSTLY_ORDER)) But otherwise, yes, this change matches what the code does. -Kees
> -----Original Message----- > From: Kees Cook <keescook@chromium.org> > Sent: Saturday, December 2, 2023 1:50 AM > To: sxwjean@me.com > Cc: vbabka@suse.cz; 42.hyeyoo@gmail.com; cl@linux.com; linux-mm@kvack.org; > penberg@kernel.org; rientjes@google.com; iamjoonsoo.kim@lge.com; > roman.gushchin@linux.dev; corbet@lwn.net; arnd@arndb.de; akpm@linux- > foundation.org; gregkh@linuxfoundation.org; linux-doc@vger.kernel.org; linux- > kernel@vger.kernel.org; Song, Xiongwei <Xiongwei.Song@windriver.com> > Subject: Re: [PATCH 3/3] mm/slub: correct the default value of slub_min_objects in doc > > CAUTION: This email comes from a non Wind River email account! > Do not click links or open attachments unless you recognize the sender and know the > content is safe. > > On Fri, Dec 01, 2023 at 11:15:05AM +0800, sxwjean@me.com wrote: > > From: Xiongwei Song <xiongwei.song@windriver.com> > > > > There is no a value assigned to slub_min_objects by default, it awlays > ^^^^^^ > > is 0 that is intailized by compiler if no assigned value by command line. > ^^^^^^^^^^ > > min_objects is calculated based on proccessor numbers in > ^^^^^^^^^^ > > calculate_order(). For more details, see commit 9b2cd506e5f2 ("slub: > > Calculate min_objects based on number of processors.") > > nit: multiple spelling mistakes here. Please double-check commit logs > with a spell checker. :) Sorry for those mistakes. Will update. Regards, Xiongwei > > > > > Signed-off-by: Xiongwei Song <xiongwei.song@windriver.com> > > --- > > Documentation/mm/slub.rst | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/mm/slub.rst b/Documentation/mm/slub.rst > > index be75971532f5..1f4399581449 100644 > > --- a/Documentation/mm/slub.rst > > +++ b/Documentation/mm/slub.rst > > @@ -150,7 +150,7 @@ list_lock once in a while to deal with partial slabs. That overhead is > > governed by the order of the allocation for each slab. The allocations > > can be influenced by kernel parameters: > > > > -.. slub_min_objects=x (default 4) > > +.. slub_min_objects=x (default 0) > > .. slub_min_order=x (default 0) > > .. slub_max_order=x (default 3 (PAGE_ALLOC_COSTLY_ORDER)) > > But otherwise, yes, this change matches what the code does. > > -Kees > > -- > Kees Cook
diff --git a/Documentation/mm/slub.rst b/Documentation/mm/slub.rst index be75971532f5..1f4399581449 100644 --- a/Documentation/mm/slub.rst +++ b/Documentation/mm/slub.rst @@ -150,7 +150,7 @@ list_lock once in a while to deal with partial slabs. That overhead is governed by the order of the allocation for each slab. The allocations can be influenced by kernel parameters: -.. slub_min_objects=x (default 4) +.. slub_min_objects=x (default 0) .. slub_min_order=x (default 0) .. slub_max_order=x (default 3 (PAGE_ALLOC_COSTLY_ORDER))