mbox series

[v2,0/4] KVM: selftests: Annotate guest printfs as such

Message ID 20231129224916.532431-1-seanjc@google.com (mailing list archive)
Headers show
Series KVM: selftests: Annotate guest printfs as such | expand

Message

Sean Christopherson Nov. 29, 2023, 10:49 p.m. UTC
Fix a handful of broken guest assert/printf messages, and annotate guest
ucall, printf, and assert helpers with __printf() so that such breakage is
detected by the compiler.

v2:
 - Annotate the relevant helpers. [Maxim]
 - Fix all other warnings (v1 fixed only the MWAIT error message)

v1: https://lore.kernel.org/all/20231107182159.404770-1-seanjc@google.com

Sean Christopherson (4):
  KVM: selftests: Fix MWAIT error message when guest assertion fails
  KVM: selftests: Fix benign %llx vs. %lx issues in guest asserts
  KVM: selftests: Fix broken assert messages in Hyper-V features test
  KVM: selftests: Annotate guest ucall, printf, and assert helpers with
    __printf()

 tools/testing/selftests/kvm/include/test_util.h        |  2 +-
 tools/testing/selftests/kvm/include/ucall_common.h     |  7 ++++---
 tools/testing/selftests/kvm/set_memory_region_test.c   |  6 +++---
 tools/testing/selftests/kvm/x86_64/hyperv_features.c   | 10 +++++-----
 .../testing/selftests/kvm/x86_64/monitor_mwait_test.c  |  6 ++++--
 .../kvm/x86_64/private_mem_conversions_test.c          |  2 +-
 .../selftests/kvm/x86_64/svm_nested_soft_inject_test.c |  4 ++--
 tools/testing/selftests/kvm/x86_64/vmx_pmu_caps_test.c |  2 +-
 tools/testing/selftests/kvm/x86_64/xcr0_cpuid_test.c   |  8 ++++----
 9 files changed, 25 insertions(+), 22 deletions(-)


base-commit: 6803fb00772cc50cd59a66bd8caaee5c84b13fcf

Comments

Sean Christopherson Dec. 1, 2023, 11:30 p.m. UTC | #1
On Wed, 29 Nov 2023 14:49:12 -0800, Sean Christopherson wrote:
> Fix a handful of broken guest assert/printf messages, and annotate guest
> ucall, printf, and assert helpers with __printf() so that such breakage is
> detected by the compiler.
> 
> v2:
>  - Annotate the relevant helpers. [Maxim]
>  - Fix all other warnings (v1 fixed only the MWAIT error message)
> 
> [...]

Applied rather quickly to kvm-x86 selftests, as I want to get these a few days
of exposure in -next before sending them to Paolo for 6.7-rc5.  I'll happily do
fixups if there is any feedback that needs to be addressed.  Thanks!

[1/4] KVM: selftests: Fix MWAIT error message when guest assertion fails
      https://github.com/kvm-x86/linux/commit/1af3bf2befc0
[2/4] KVM: selftests: Fix benign %llx vs. %lx issues in guest asserts
      https://github.com/kvm-x86/linux/commit/4d53dcc5d0bc
[3/4] KVM: selftests: Fix broken assert messages in Hyper-V features test
      https://github.com/kvm-x86/linux/commit/f813e6d41baf
[4/4] KVM: selftests: Annotate guest ucall, printf, and assert helpers with __printf()
      https://github.com/kvm-x86/linux/commit/1b2658e4c709

--
https://github.com/kvm-x86/linux/tree/next