| Message ID | 20231204172510.35041-3-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
On Mon, Dec 4, 2023 at 6:25 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > The DA9061 watchdog is identical to DA9062 watchdog, so no driver changes > are required. The fallback compatible string "dlg,da9062-watchdog" will be > used on DA9061 watchdog. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > v3->v3.1: > * Dropped comment for d9061 watchdog fallback. > * Replaced enum->const for dlg,da9061-watchdog and its fallback. Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Mon, Dec 04, 2023 at 05:25:04PM +0000, Biju Das wrote: > The DA9061 watchdog is identical to DA9062 watchdog, so no driver changes > are required. The fallback compatible string "dlg,da9062-watchdog" will be > used on DA9061 watchdog. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Acked-by: Conor Dooley <conor.dooley@microchip.com>
On Mon, Dec 04, 2023 at 05:25:04PM +0000, Biju Das wrote: > The DA9061 watchdog is identical to DA9062 watchdog, so no driver changes > are required. The fallback compatible string "dlg,da9062-watchdog" will be > used on DA9061 watchdog. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > v3->v3.1: > * Dropped comment for d9061 watchdog fallback. > * Replaced enum->const for dlg,da9061-watchdog and its fallback. > v2->v3: > * No change > v2: > * New patch > --- > .../bindings/watchdog/dlg,da9062-watchdog.yaml | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml > index f058628bb632..7c63b99dac85 100644 > --- a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml > +++ b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml > @@ -14,9 +14,13 @@ allOf: > > properties: > compatible: > - enum: > - - dlg,da9061-watchdog > - - dlg,da9062-watchdog > + oneOf: > + - items: > + - enum: > + - dlg,da9062-watchdog > + - items: > + - const: dlg,da9061-watchdog > + - const: dlg,da9062-watchdog > > dlg,use-sw-pm: > type: boolean > -- > 2.39.2 >
On Tue, Dec 12, 2023 at 08:56:00AM -0800, Guenter Roeck wrote: > On Mon, Dec 04, 2023 at 05:25:04PM +0000, Biju Das wrote: > > The DA9061 watchdog is identical to DA9062 watchdog, so no driver changes > > are required. The fallback compatible string "dlg,da9062-watchdog" will be > > used on DA9061 watchdog. > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > Reviewed-by: Guenter Roeck <linux@roeck-us.net> There's a v5 of this series already FYI
On Tue, Dec 12, 2023 at 05:08:45PM +0000, Conor Dooley wrote: > On Tue, Dec 12, 2023 at 08:56:00AM -0800, Guenter Roeck wrote: > > On Mon, Dec 04, 2023 at 05:25:04PM +0000, Biju Das wrote: > > > The DA9061 watchdog is identical to DA9062 watchdog, so no driver changes > > > are required. The fallback compatible string "dlg,da9062-watchdog" will be > > > used on DA9061 watchdog. > > > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > > > Reviewed-by: Guenter Roeck <linux@roeck-us.net> > > There's a v5 of this series already FYI Yes, I noticed too late. Sorry. Happens if one is way backlogged with reviews. Guenter
diff --git a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml index f058628bb632..7c63b99dac85 100644 --- a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml +++ b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml @@ -14,9 +14,13 @@ allOf: properties: compatible: - enum: - - dlg,da9061-watchdog - - dlg,da9062-watchdog + oneOf: + - items: + - enum: + - dlg,da9062-watchdog + - items: + - const: dlg,da9061-watchdog + - const: dlg,da9062-watchdog dlg,use-sw-pm: type: boolean
The DA9061 watchdog is identical to DA9062 watchdog, so no driver changes are required. The fallback compatible string "dlg,da9062-watchdog" will be used on DA9061 watchdog. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- v3->v3.1: * Dropped comment for d9061 watchdog fallback. * Replaced enum->const for dlg,da9061-watchdog and its fallback. v2->v3: * No change v2: * New patch --- .../bindings/watchdog/dlg,da9062-watchdog.yaml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)