| Message ID | 20231205-drm_aux_bridge-fixes-v1-2-d242a0ae9df4@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 03c0343bdf8d43fee6dfe92a7b66308b60e9e77c |
| Headers | show |
| Series | A few fixes for transparent bridge support | expand |
On 12/5/23 12:13, Nathan Chancellor wrote: > CONFIG_DRM_AUX_HPD_BRIDGE depends on CONFIG_OF but that dependency is > not included when CONFIG_TYPEC_QCOM_PMIC selects it, resulting in a > Kconfig warning when CONFIG_OF is disabled: > > WARNING: unmet direct dependencies detected for DRM_AUX_HPD_BRIDGE > Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && OF [=n] > Selected by [m]: > - TYPEC_QCOM_PMIC [=m] && USB_SUPPORT [=y] && TYPEC [=m] && TYPEC_TCPM [=m] && (ARCH_QCOM || COMPILE_TEST [=y]) && (DRM [=m] || DRM [=m]=n) && DRM_BRIDGE [=y] > > Only select CONFIG_DRM_AUX_HPD_BRIDGE with both CONFIG_DRM_BRIDGE and > CONFIG_OF to clear up the warning. > > Fixes: 7d9f1b72b296 ("usb: typec: qcom-pmic-typec: switch to DRM_AUX_HPD_BRIDGE") > Signed-off-by: Nathan Chancellor <nathan@kernel.org> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
On 05/12/2023 21:13, Nathan Chancellor wrote: > CONFIG_DRM_AUX_HPD_BRIDGE depends on CONFIG_OF but that dependency is > not included when CONFIG_TYPEC_QCOM_PMIC selects it, resulting in a > Kconfig warning when CONFIG_OF is disabled: > > WARNING: unmet direct dependencies detected for DRM_AUX_HPD_BRIDGE > Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && OF [=n] > Selected by [m]: > - TYPEC_QCOM_PMIC [=m] && USB_SUPPORT [=y] && TYPEC [=m] && TYPEC_TCPM [=m] && (ARCH_QCOM || COMPILE_TEST [=y]) && (DRM [=m] || DRM [=m]=n) && DRM_BRIDGE [=y] > > Only select CONFIG_DRM_AUX_HPD_BRIDGE with both CONFIG_DRM_BRIDGE and > CONFIG_OF to clear up the warning. > > Fixes: 7d9f1b72b296 ("usb: typec: qcom-pmic-typec: switch to DRM_AUX_HPD_BRIDGE") > Signed-off-by: Nathan Chancellor <nathan@kernel.org> > --- > drivers/usb/typec/tcpm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/tcpm/Kconfig b/drivers/usb/typec/tcpm/Kconfig > index 64d5421c69e6..8cdd84ca5d6f 100644 > --- a/drivers/usb/typec/tcpm/Kconfig > +++ b/drivers/usb/typec/tcpm/Kconfig > @@ -80,7 +80,7 @@ config TYPEC_QCOM_PMIC > tristate "Qualcomm PMIC USB Type-C Port Controller Manager driver" > depends on ARCH_QCOM || COMPILE_TEST > depends on DRM || DRM=n > - select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE > + select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF > help > A Type-C port and Power Delivery driver which aggregates two > discrete pieces of silicon in the PM8150b PMIC block: the > Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
On Tue, Dec 05, 2023 at 01:13:35PM -0700, Nathan Chancellor wrote: > CONFIG_DRM_AUX_HPD_BRIDGE depends on CONFIG_OF but that dependency is > not included when CONFIG_TYPEC_QCOM_PMIC selects it, resulting in a > Kconfig warning when CONFIG_OF is disabled: > > WARNING: unmet direct dependencies detected for DRM_AUX_HPD_BRIDGE > Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && OF [=n] > Selected by [m]: > - TYPEC_QCOM_PMIC [=m] && USB_SUPPORT [=y] && TYPEC [=m] && TYPEC_TCPM [=m] && (ARCH_QCOM || COMPILE_TEST [=y]) && (DRM [=m] || DRM [=m]=n) && DRM_BRIDGE [=y] > > Only select CONFIG_DRM_AUX_HPD_BRIDGE with both CONFIG_DRM_BRIDGE and > CONFIG_OF to clear up the warning. > > Fixes: 7d9f1b72b296 ("usb: typec: qcom-pmic-typec: switch to DRM_AUX_HPD_BRIDGE") > Signed-off-by: Nathan Chancellor <nathan@kernel.org> Shouldn't DRM_BRIDGE depend on/select OF instead? Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/tcpm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/tcpm/Kconfig b/drivers/usb/typec/tcpm/Kconfig > index 64d5421c69e6..8cdd84ca5d6f 100644 > --- a/drivers/usb/typec/tcpm/Kconfig > +++ b/drivers/usb/typec/tcpm/Kconfig > @@ -80,7 +80,7 @@ config TYPEC_QCOM_PMIC > tristate "Qualcomm PMIC USB Type-C Port Controller Manager driver" > depends on ARCH_QCOM || COMPILE_TEST > depends on DRM || DRM=n > - select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE > + select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF > help > A Type-C port and Power Delivery driver which aggregates two > discrete pieces of silicon in the PM8150b PMIC block: the > > -- > 2.43.0
diff --git a/drivers/usb/typec/tcpm/Kconfig b/drivers/usb/typec/tcpm/Kconfig index 64d5421c69e6..8cdd84ca5d6f 100644 --- a/drivers/usb/typec/tcpm/Kconfig +++ b/drivers/usb/typec/tcpm/Kconfig @@ -80,7 +80,7 @@ config TYPEC_QCOM_PMIC tristate "Qualcomm PMIC USB Type-C Port Controller Manager driver" depends on ARCH_QCOM || COMPILE_TEST depends on DRM || DRM=n - select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE + select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF help A Type-C port and Power Delivery driver which aggregates two discrete pieces of silicon in the PM8150b PMIC block: the
CONFIG_DRM_AUX_HPD_BRIDGE depends on CONFIG_OF but that dependency is not included when CONFIG_TYPEC_QCOM_PMIC selects it, resulting in a Kconfig warning when CONFIG_OF is disabled: WARNING: unmet direct dependencies detected for DRM_AUX_HPD_BRIDGE Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && OF [=n] Selected by [m]: - TYPEC_QCOM_PMIC [=m] && USB_SUPPORT [=y] && TYPEC [=m] && TYPEC_TCPM [=m] && (ARCH_QCOM || COMPILE_TEST [=y]) && (DRM [=m] || DRM [=m]=n) && DRM_BRIDGE [=y] Only select CONFIG_DRM_AUX_HPD_BRIDGE with both CONFIG_DRM_BRIDGE and CONFIG_OF to clear up the warning. Fixes: 7d9f1b72b296 ("usb: typec: qcom-pmic-typec: switch to DRM_AUX_HPD_BRIDGE") Signed-off-by: Nathan Chancellor <nathan@kernel.org> --- drivers/usb/typec/tcpm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)