mbox series

[v2,0/4] drm: Fix errors about uninitialized/wrong variables

Message ID 20231103-uninit-fixes-v2-0-c22b2444f5f5@ideasonboard.com (mailing list archive)
Headers show
Series drm: Fix errors about uninitialized/wrong variables | expand

Message

Tomi Valkeinen Nov. 3, 2023, 1:14 p.m. UTC
Fix cases where smatch reports a use of an uninitialized variable, and
one where the variable is initialized but contains wrong value.

 Tomi

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
---
Changes in v2:
- Added two more fixes
- Link to v1: https://lore.kernel.org/r/20230804-uninit-fixes-v1-0-a60772c04db5@ideasonboard.com

---
Tomi Valkeinen (4):
      drm/drm_file: fix use of uninitialized variable
      drm/framebuffer: Fix use of uninitialized variable
      drm/bridge: cdns-mhdp8546: Fix use of uninitialized variable
      drm/bridge: tc358767: Fix return value on error case

 drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.c | 3 ++-
 drivers/gpu/drm/bridge/tc358767.c                   | 2 +-
 drivers/gpu/drm/drm_file.c                          | 2 +-
 drivers/gpu/drm/drm_framebuffer.c                   | 2 +-
 4 files changed, 5 insertions(+), 4 deletions(-)
---
base-commit: 9d7c8c066916f231ca0ed4e4fce6c4b58ca3e451
change-id: 20230804-uninit-fixes-188f92d60ac3

Best regards,

Comments

Tomi Valkeinen Dec. 6, 2023, 12:50 p.m. UTC | #1
Hi all,

On 03/11/2023 15:14, Tomi Valkeinen wrote:
> Fix cases where smatch reports a use of an uninitialized variable, and
> one where the variable is initialized but contains wrong value.
> 
>   Tomi
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> ---
> Changes in v2:
> - Added two more fixes
> - Link to v1: https://lore.kernel.org/r/20230804-uninit-fixes-v1-0-a60772c04db5@ideasonboard.com
> 
> ---
> Tomi Valkeinen (4):
>        drm/drm_file: fix use of uninitialized variable
>        drm/framebuffer: Fix use of uninitialized variable
>        drm/bridge: cdns-mhdp8546: Fix use of uninitialized variable
>        drm/bridge: tc358767: Fix return value on error case
> 
>   drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.c | 3 ++-
>   drivers/gpu/drm/bridge/tc358767.c                   | 2 +-
>   drivers/gpu/drm/drm_file.c                          | 2 +-
>   drivers/gpu/drm/drm_framebuffer.c                   | 2 +-
>   4 files changed, 5 insertions(+), 4 deletions(-)
> ---
> base-commit: 9d7c8c066916f231ca0ed4e4fce6c4b58ca3e451
> change-id: 20230804-uninit-fixes-188f92d60ac3
> 
> Best regards,

Ping on this (or I'll forget the series...).

  Tomi
Maxime Ripard Dec. 6, 2023, 2:31 p.m. UTC | #2
On Wed, Dec 06, 2023 at 02:50:57PM +0200, Tomi Valkeinen wrote:
> Hi all,
> 
> On 03/11/2023 15:14, Tomi Valkeinen wrote:
> > Fix cases where smatch reports a use of an uninitialized variable, and
> > one where the variable is initialized but contains wrong value.
> > 
> >   Tomi
> > 
> > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> > ---
> > Changes in v2:
> > - Added two more fixes
> > - Link to v1: https://lore.kernel.org/r/20230804-uninit-fixes-v1-0-a60772c04db5@ideasonboard.com
> > 
> > ---
> > Tomi Valkeinen (4):
> >        drm/drm_file: fix use of uninitialized variable
> >        drm/framebuffer: Fix use of uninitialized variable
> >        drm/bridge: cdns-mhdp8546: Fix use of uninitialized variable
> >        drm/bridge: tc358767: Fix return value on error case
> > 
> >   drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.c | 3 ++-
> >   drivers/gpu/drm/bridge/tc358767.c                   | 2 +-
> >   drivers/gpu/drm/drm_file.c                          | 2 +-
> >   drivers/gpu/drm/drm_framebuffer.c                   | 2 +-
> >   4 files changed, 5 insertions(+), 4 deletions(-)
> > ---
> > base-commit: 9d7c8c066916f231ca0ed4e4fce6c4b58ca3e451
> > change-id: 20230804-uninit-fixes-188f92d60ac3
> > 
> > Best regards,
> 
> Ping on this (or I'll forget the series...).

Acked-by: Maxime Ripard <mripard@kernel.org>

Maxime