| Message ID | 20231205-drm_aux_bridge-fixes-v1-1-d242a0ae9df4@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5908cbe82ef77f6019349c450d7f1c8b3c29bb0e |
| Headers | show |
| Series | A few fixes for transparent bridge support | expand |
On 12/5/23 12:13, Nathan Chancellor wrote: > CONFIG_DRM_AUX_BRIDGE depends on CONFIG_OF but that dependency is not > included when CONFIG_TYPEC_MUX_NB7VPQ904M selects it, resulting in a > Kconfig warning when CONFIG_OF is disabled: > > WARNING: unmet direct dependencies detected for DRM_AUX_BRIDGE > Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && OF [=n] > Selected by [y]: > - TYPEC_MUX_NB7VPQ904M [=y] && USB_SUPPORT [=y] && TYPEC [=y] && I2C [=y] && (DRM [=y] || DRM [=y]=n) && DRM_BRIDGE [=y] > > Only select CONFIG_DRM_AUX_BRIDGE with both CONFIG_DRM_BRIDGE and > CONFIG_OF to clear up the warning. > > Fixes: c5d296bad640 ("usb: typec: nb7vpq904m: switch to DRM_AUX_BRIDGE") > Signed-off-by: Nathan Chancellor <nathan@kernel.org> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
On 05/12/2023 22:13, Nathan Chancellor wrote: > CONFIG_DRM_AUX_BRIDGE depends on CONFIG_OF but that dependency is not > included when CONFIG_TYPEC_MUX_NB7VPQ904M selects it, resulting in a > Kconfig warning when CONFIG_OF is disabled: > > WARNING: unmet direct dependencies detected for DRM_AUX_BRIDGE > Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && OF [=n] > Selected by [y]: > - TYPEC_MUX_NB7VPQ904M [=y] && USB_SUPPORT [=y] && TYPEC [=y] && I2C [=y] && (DRM [=y] || DRM [=y]=n) && DRM_BRIDGE [=y] > > Only select CONFIG_DRM_AUX_BRIDGE with both CONFIG_DRM_BRIDGE and > CONFIG_OF to clear up the warning. > > Fixes: c5d296bad640 ("usb: typec: nb7vpq904m: switch to DRM_AUX_BRIDGE") > Signed-off-by: Nathan Chancellor <nathan@kernel.org> > --- > drivers/usb/typec/mux/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) For this patch we'd need an ack from Heikki.
On Tue, Dec 05, 2023 at 01:13:34PM -0700, Nathan Chancellor wrote: > CONFIG_DRM_AUX_BRIDGE depends on CONFIG_OF but that dependency is not > included when CONFIG_TYPEC_MUX_NB7VPQ904M selects it, resulting in a > Kconfig warning when CONFIG_OF is disabled: > > WARNING: unmet direct dependencies detected for DRM_AUX_BRIDGE > Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && OF [=n] > Selected by [y]: > - TYPEC_MUX_NB7VPQ904M [=y] && USB_SUPPORT [=y] && TYPEC [=y] && I2C [=y] && (DRM [=y] || DRM [=y]=n) && DRM_BRIDGE [=y] > > Only select CONFIG_DRM_AUX_BRIDGE with both CONFIG_DRM_BRIDGE and > CONFIG_OF to clear up the warning. > > Fixes: c5d296bad640 ("usb: typec: nb7vpq904m: switch to DRM_AUX_BRIDGE") > Signed-off-by: Nathan Chancellor <nathan@kernel.org> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/mux/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/mux/Kconfig b/drivers/usb/typec/mux/Kconfig > index 5120942f309d..38416fb0cc3c 100644 > --- a/drivers/usb/typec/mux/Kconfig > +++ b/drivers/usb/typec/mux/Kconfig > @@ -40,7 +40,7 @@ config TYPEC_MUX_NB7VPQ904M > tristate "On Semiconductor NB7VPQ904M Type-C redriver driver" > depends on I2C > depends on DRM || DRM=n > - select DRM_AUX_BRIDGE if DRM_BRIDGE > + select DRM_AUX_BRIDGE if DRM_BRIDGE && OF > select REGMAP_I2C > help > Say Y or M if your system has a On Semiconductor NB7VPQ904M Type-C > > -- > 2.43.0
diff --git a/drivers/usb/typec/mux/Kconfig b/drivers/usb/typec/mux/Kconfig index 5120942f309d..38416fb0cc3c 100644 --- a/drivers/usb/typec/mux/Kconfig +++ b/drivers/usb/typec/mux/Kconfig @@ -40,7 +40,7 @@ config TYPEC_MUX_NB7VPQ904M tristate "On Semiconductor NB7VPQ904M Type-C redriver driver" depends on I2C depends on DRM || DRM=n - select DRM_AUX_BRIDGE if DRM_BRIDGE + select DRM_AUX_BRIDGE if DRM_BRIDGE && OF select REGMAP_I2C help Say Y or M if your system has a On Semiconductor NB7VPQ904M Type-C
CONFIG_DRM_AUX_BRIDGE depends on CONFIG_OF but that dependency is not included when CONFIG_TYPEC_MUX_NB7VPQ904M selects it, resulting in a Kconfig warning when CONFIG_OF is disabled: WARNING: unmet direct dependencies detected for DRM_AUX_BRIDGE Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && OF [=n] Selected by [y]: - TYPEC_MUX_NB7VPQ904M [=y] && USB_SUPPORT [=y] && TYPEC [=y] && I2C [=y] && (DRM [=y] || DRM [=y]=n) && DRM_BRIDGE [=y] Only select CONFIG_DRM_AUX_BRIDGE with both CONFIG_DRM_BRIDGE and CONFIG_OF to clear up the warning. Fixes: c5d296bad640 ("usb: typec: nb7vpq904m: switch to DRM_AUX_BRIDGE") Signed-off-by: Nathan Chancellor <nathan@kernel.org> --- drivers/usb/typec/mux/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)