diff mbox series

[v2,4/5] dt-bindings: arm: rockchip: Add Cool Pi CM5 EVB

Message ID 20231210080607.1667517-1-andyshrk@163.com (mailing list archive)
State New, archived
Headers show
Series Add 2 rk3588 based boards from Cool Pi | expand

Commit Message

Andy Yan Dec. 10, 2023, 8:06 a.m. UTC
Add Cool Pi CM5 EVB, a board powered by RK3588

Signed-off-by: Andy Yan <andyshrk@163.com>

---

Changes in v2:
- change board compatible from "CoolPi CM5 EVB" to "coolpi,pi-cm5-evb"

 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Krzysztof Kozlowski Dec. 10, 2023, 11:11 a.m. UTC | #1
On 10/12/2023 09:06, Andy Yan wrote:
> Add Cool Pi CM5 EVB, a board powered by RK3588
> 
> Signed-off-by: Andy Yan <andyshrk@163.com>
> 
> ---
> 
> Changes in v2:
> - change board compatible from "CoolPi CM5 EVB" to "coolpi,pi-cm5-evb"
> 
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 11d03035f3db..4da83bbd642a 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -95,6 +95,11 @@ properties:
>            - const: chipspark,rayeager-px2
>            - const: rockchip,rk3066a
>  
> +      - description: Cool Pi Compute Module 5(CM5) EVB
> +        items:
> +          - const: coolpi,pi-cm5-evb

If it is module you are maybe missing here module DTSI and compatible.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Andy Yan Dec. 11, 2023, 7:46 a.m. UTC | #2
Hi Krzysztof:

At 2023-12-10 19:11:33, "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org> wrote:
>On 10/12/2023 09:06, Andy Yan wrote:
>> Add Cool Pi CM5 EVB, a board powered by RK3588
>> 
>> Signed-off-by: Andy Yan <andyshrk@163.com>
>> 
>> ---
>> 
>> Changes in v2:
>> - change board compatible from "CoolPi CM5 EVB" to "coolpi,pi-cm5-evb"
>> 
>>  Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
>>  1 file changed, 5 insertions(+)
>> 
>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> index 11d03035f3db..4da83bbd642a 100644
>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> @@ -95,6 +95,11 @@ properties:
>>            - const: chipspark,rayeager-px2
>>            - const: rockchip,rk3066a
>>  
>> +      - description: Cool Pi Compute Module 5(CM5) EVB
>> +        items:
>> +          - const: coolpi,pi-cm5-evb
>
>If it is module you are maybe missing here module DTSI and compatible.
>

Yes, it is a core board(CM5) + mother board = CM5 EVB,this is
the  variant I current have, I want to keep the dts as it is now,I will
convert it to a dtsi when I get another variant for this core board(CM5).

>Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
>Best regards,
>Krzysztof
>
>
>_______________________________________________
>linux-arm-kernel mailing list
>linux-arm-kernel@lists.infradead.org
>http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 11d03035f3db..4da83bbd642a 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -95,6 +95,11 @@  properties:
           - const: chipspark,rayeager-px2
           - const: rockchip,rk3066a
 
+      - description: Cool Pi Compute Module 5(CM5) EVB
+        items:
+          - const: coolpi,pi-cm5-evb
+          - const: rockchip,rk3588
+
       - description: Cool Pi 4 Model B
         items:
           - const: coolpi,pi-4b