| Message ID | 3cad5ffd-22dd-4bd5-8c08-1a5530489923@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ALSA: hda/realtek: Add quirk for ASUS ROG GV302XA | expand |
On Tue, 12 Dec 2023 08:43:36 +0100, Clément Villeret wrote: > > Commit message : Please drop a superfluous tag. > Asus ROG Flowx13 (GV302XA) seems require same patch as others asus product (UM3402YAR, UM3406HA...). This permit to load the correct firmware and don't loose audio after waking up from sleep or hibernate. Your Signed-off-by tag is mandatory for the patch to be merged to the upstream. Please take a look at Documentation/process/submitting-patches.rst for details. About the code change: > @@ -9954,6 +9954,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A), > SND_PCI_QUIRK(0x1043, 0x1573, "ASUS GZ301V", ALC285_FIXUP_ASUS_HEADSET_MIC), > SND_PCI_QUIRK(0x1043, 0x1662, "ASUS GV301QH", ALC294_FIXUP_ASUS_DUAL_SPK), > + SND_PCI_QUIRK(0x1043, 0x1533, "ASUS GV302XA", ALC287_FIXUP_CS35L41_I2C_2), > SND_PCI_QUIRK(0x1043, 0x1663, "ASUS GU603ZV", ALC285_FIXUP_ASUS_HEADSET_MIC), > SND_PCI_QUIRK(0x1043, 0x1683, "ASUS UM3402YAR", ALC287_FIXUP_CS35L41_I2C_2), > SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603", ALC289_FIXUP_ASUS_GA401), The table is sorted in PCI SSID order. Please put at the right position. Could you resubmit the patch with the corrections above? thanks, Takashi
On Tue, 12 Dec 2023 18:30:44 +0100, Clément Villeret wrote: > > > From 84a165a7abc87c64bc1ab1663807b28fe291cb80 Mon Sep 17 00:00:00 2001 > From: Clement Villeret <clement.villeret@gmail.com> > Date: Tue, 12 Dec 2023 18:23:58 +0100 > Subject: [PATCH] ALSA: hda/realtek: Add quirk for ASUS ROG GV302XA > Signed-off-by: Clément Villeret <clement.villeret@gmail.com> > Commit-message: Asus ROG Flowx13 (GV302XA) seems require same patch as others > asus product Hmm, it became worse... First off, please don't use the reply-to for a new patch. Just resubmit. The Signed-off-by tag must be added after the patch description, and the patch description is just a normal mail body. It's no such mail header. If you committed to your tree locally, it's all done there; the patch description is the commit message that includes a line "Signed-off-by: ...." at the end of the description. And, above all, the patch context is no longer applicable at this time (while it was OK at the previous time); the tabs are incorrectly replaced with spaces. At best, submit the patch via git-send-email. thanks, Takashi > --- > sound/pci/hda/patch_realtek.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index 0377912e9264..eb9f617b6273 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -9953,6 +9953,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x1043, 0x1483, "ASUS GU603V", > ALC285_FIXUP_ASUS_HEADSET_MIC), > SND_PCI_QUIRK(0x1043, 0x1493, "ASUS GV601V", > ALC285_FIXUP_ASUS_HEADSET_MIC), > SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", > ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A), > + SND_PCI_QUIRK(0x1043, 0x1533, "ASUS GV302XA", > ALC287_FIXUP_CS35L41_I2C_2), > SND_PCI_QUIRK(0x1043, 0x1573, "ASUS GZ301V", > ALC285_FIXUP_ASUS_HEADSET_MIC), > SND_PCI_QUIRK(0x1043, 0x1662, "ASUS GV301QH", > ALC294_FIXUP_ASUS_DUAL_SPK), > SND_PCI_QUIRK(0x1043, 0x1663, "ASUS GU603ZV", > ALC285_FIXUP_ASUS_HEADSET_MIC), > -- > 2.43.0 > On 12/12/2023 08:46, Takashi Iwai wrote: > > On Tue, 12 Dec 2023 08:43:36 +0100, > Clément Villeret wrote: > > Commit message : > > Please drop a superfluous tag. > > Asus ROG Flowx13 (GV302XA) seems require same patch as others asus product (UM3402YAR, UM3406HA...). This permit to load the correct firmware and don't loose audio after waking up from sleep or hibernate. > > Your Signed-off-by tag is mandatory for the patch to be merged to the > upstream. Please take a look at > Documentation/process/submitting-patches.rst for details. > > About the code change: > > @@ -9954,6 +9954,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A), > SND_PCI_QUIRK(0x1043, 0x1573, "ASUS GZ301V", ALC285_FIXUP_ASUS_HEADSET_MIC), > SND_PCI_QUIRK(0x1043, 0x1662, "ASUS GV301QH", ALC294_FIXUP_ASUS_DUAL_SPK), > + SND_PCI_QUIRK(0x1043, 0x1533, "ASUS GV302XA", ALC287_FIXUP_CS35L41_I2C_2), > SND_PCI_QUIRK(0x1043, 0x1663, "ASUS GU603ZV", ALC285_FIXUP_ASUS_HEADSET_MIC), > SND_PCI_QUIRK(0x1043, 0x1683, "ASUS UM3402YAR", ALC287_FIXUP_CS35L41_I2C_2), > SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603", ALC289_FIXUP_ASUS_GA401), > > The table is sorted in PCI SSID order. Please put at the right > position. > > Could you resubmit the patch with the corrections above? > > thanks, > > Takashi >
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index f9ddacfd920e..acbb88d777a2 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -9954,6 +9954,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A), SND_PCI_QUIRK(0x1043, 0x1573, "ASUS GZ301V", ALC285_FIXUP_ASUS_HEADSET_MIC), SND_PCI_QUIRK(0x1043, 0x1662, "ASUS GV301QH", ALC294_FIXUP_ASUS_DUAL_SPK), + SND_PCI_QUIRK(0x1043, 0x1533, "ASUS GV302XA", ALC287_FIXUP_CS35L41_I2C_2), SND_PCI_QUIRK(0x1043, 0x1663, "ASUS GU603ZV", ALC285_FIXUP_ASUS_HEADSET_MIC), SND_PCI_QUIRK(0x1043, 0x1683, "ASUS UM3402YAR", ALC287_FIXUP_CS35L41_I2C_2), SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603", ALC289_FIXUP_ASUS_GA401),