| Message ID | 20231212050831.982-1-shenghao-ding@ti.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 645994d21287a1ad2f637818d737f7a3d84e97d7 |
| Headers | show |
| Series | [v1] ASoC: tas2562: remove tas2563 into driver | expand |
On 12/12/2023 06:08, Shenghao Ding wrote: > Remove tas2563 from tas2562, it will be supported in separated driver code. > Why? I was not aware that you duplicate tas2563 in your other patch, so that part need explanation. This part as well - why do we want to remove its support from the Linux? What about users? After applying this code they don't have support for their device! Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Tuesday, December 12, 2023 4:23 PM > To: Ding, Shenghao <shenghao-ding@ti.com>; broonie@kernel.org; > conor+dt@kernel.org > Cc: robh+dt@kernel.org; andriy.shevchenko@linux.intel.com; > devicetree@vger.kernel.org; lgirdwood@gmail.com; perex@perex.cz; pierre- > louis.bossart@linux.intel.com; 13916275206@139.com; linux- > sound@vger.kernel.org; linux-kernel@vger.kernel.org; > liam.r.girdwood@intel.com; soyer@irl.hu; tiwai@suse.de; Gupta, Peeyush > <peeyush@ti.com>; Navada Kanyana, Mukund <navada@ti.com> > Subject: [EXTERNAL] Re: [PATCH v1] ASoC: tas2562: remove tas2563 into driver > > On 12/12/2023 06:08, Shenghao Ding wrote: > > Remove tas2563 from tas2562, it will be supported in separated driver code. > > > > Why? I was not aware that you duplicate tas2563 in your other patch, so that > part need explanation. This part as well - why do we want to remove its > support from the Linux? What about users? After applying this code they don't > have support for their device! We plan to add tas2563 into tas2781, current driver can't support dsp mode, only a bypass mode. > > Best regards, > Krzysztof
On Tue, Dec 12, 2023 at 01:08:31PM +0800, Shenghao Ding wrote:
> Remove tas2563 from tas2562, it will be supported in separated driver code.
It would be better to do this as part of adding the new, split out
support - otherwise users might get a release which temporarily drops
the support.
On Tue, Dec 12, 2023 at 01:08:31PM +0800, Shenghao Ding wrote:
> Remove tas2563 from tas2562, it will be supported in separated driver code.
No objection from the code perspective. The Q is, what is the behaviour of the
current users? Imagine we have a used of this chip and this driver gets it
enumerated. Does it work? if so, this patch can not be applied right now.
Otherwise the commit message above is missing an elaboration of the case.
diff --git a/sound/soc/codecs/tas2562.c b/sound/soc/codecs/tas2562.c index 962c2cdfa017..54561ae598b8 100644 --- a/sound/soc/codecs/tas2562.c +++ b/sound/soc/codecs/tas2562.c @@ -59,7 +59,6 @@ struct tas2562_data { enum tas256x_model { TAS2562, - TAS2563, TAS2564, TAS2110, }; @@ -721,7 +720,6 @@ static int tas2562_parse_dt(struct tas2562_data *tas2562) static const struct i2c_device_id tas2562_id[] = { { "tas2562", TAS2562 }, - { "tas2563", TAS2563 }, { "tas2564", TAS2564 }, { "tas2110", TAS2110 }, { } @@ -770,7 +768,6 @@ static int tas2562_probe(struct i2c_client *client) #ifdef CONFIG_OF static const struct of_device_id tas2562_of_match[] = { { .compatible = "ti,tas2562", }, - { .compatible = "ti,tas2563", }, { .compatible = "ti,tas2564", }, { .compatible = "ti,tas2110", }, { },
Remove tas2563 from tas2562, it will be supported in separated driver code. Signed-off-by: Shenghao Ding <shenghao-ding@ti.com> --- sound/soc/codecs/tas2562.c | 3 --- 1 file changed, 3 deletions(-)