diff mbox series

[v2,1/1] dt-bindings: watchdog: starfive,jh7100-wdt: Add compatible for JH8100

Message ID 20231212031731.2498584-2-jisheng.teoh@starfivetech.com (mailing list archive)
State Superseded
Headers show
Series Add StarFive JH8100 watchdog | expand

Commit Message

Ji Sheng Teoh Dec. 12, 2023, 3:17 a.m. UTC 
Add "starfive,jh8100-wdt" compatible string for StarFive's JH8100
watchdog.
Since JH8100 watchdog only has 1 reset signal, update binding
document to support one reset for "starfive,jh8100-wdt" compatible.

Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com>
Signed-off-by: Ji Sheng Teoh <jisheng.teoh@starfivetech.com>
---
 .../devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml       | 2 ++
 1 file changed, 2 insertions(+)

Comments

Conor Dooley Dec. 12, 2023, 4:46 p.m. UTC | #1 
On Tue, Dec 12, 2023 at 11:17:31AM +0800, Ji Sheng Teoh wrote:
> Add "starfive,jh8100-wdt" compatible string for StarFive's JH8100
> watchdog.
> Since JH8100 watchdog only has 1 reset signal, update binding
> document to support one reset for "starfive,jh8100-wdt" compatible.
> 
> Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com>
> Signed-off-by: Ji Sheng Teoh <jisheng.teoh@starfivetech.com>
> ---
>  .../devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml       | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> index 68f3f6fd08a6..02572b16ac08 100644
> --- a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> @@ -27,6 +27,7 @@ properties:
>      enum:
>        - starfive,jh7100-wdt
>        - starfive,jh7110-wdt
> +      - starfive,jh8100-wdt
>  
>    reg:
>      maxItems: 1
> @@ -45,6 +46,7 @@ properties:
>        - const: core
>  
>    resets:
> +    minItems: 1
>      items:
>        - description: APB reset
>        - description: Core reset

This relaxes the constraints for the existing devices, please add per
compatible constraints to avoid doing so.
Conor Dooley Dec. 12, 2023, 4:47 p.m. UTC | #2 
On Tue, Dec 12, 2023 at 04:46:00PM +0000, Conor Dooley wrote:
> On Tue, Dec 12, 2023 at 11:17:31AM +0800, Ji Sheng Teoh wrote:
> > Add "starfive,jh8100-wdt" compatible string for StarFive's JH8100
> > watchdog.
> > Since JH8100 watchdog only has 1 reset signal, update binding
> > document to support one reset for "starfive,jh8100-wdt" compatible.
> > 
> > Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com>
> > Signed-off-by: Ji Sheng Teoh <jisheng.teoh@starfivetech.com>
> > ---
> >  .../devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml       | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > index 68f3f6fd08a6..02572b16ac08 100644
> > --- a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > @@ -27,6 +27,7 @@ properties:
> >      enum:
> >        - starfive,jh7100-wdt
> >        - starfive,jh7110-wdt
> > +      - starfive,jh8100-wdt
> >  
> >    reg:
> >      maxItems: 1
> > @@ -45,6 +46,7 @@ properties:
> >        - const: core
> >  
> >    resets:
> > +    minItems: 1
> >      items:
> >        - description: APB reset
> >        - description: Core reset
> 
> This relaxes the constraints for the existing devices, please add per
> compatible constraints to avoid doing so.

Also, you do not appear to have implemented the request from Krzysztof
to express compatibility with the jh7110.
Ji Sheng Teoh Dec. 13, 2023, 2:57 a.m. UTC | #3 
On Tue, 12 Dec 2023 16:47:59 +0000
Conor Dooley <conor@kernel.org> wrote:

> On Tue, Dec 12, 2023 at 04:46:00PM +0000, Conor Dooley wrote:
> > On Tue, Dec 12, 2023 at 11:17:31AM +0800, Ji Sheng Teoh wrote:  
> > > Add "starfive,jh8100-wdt" compatible string for StarFive's JH8100
> > > watchdog.
> > > Since JH8100 watchdog only has 1 reset signal, update binding
> > > document to support one reset for "starfive,jh8100-wdt"
> > > compatible.
> > > 
> > > Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com>
> > > Signed-off-by: Ji Sheng Teoh <jisheng.teoh@starfivetech.com>
> > > ---
> > >  .../devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > | 2 ++ 1 file changed, 2 insertions(+)
> > > 
> > > diff --git
> > > a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > index 68f3f6fd08a6..02572b16ac08 100644 ---
> > > a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > +++
> > > b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > @@ -27,6 +27,7 @@ properties: enum:
> > >        - starfive,jh7100-wdt
> > >        - starfive,jh7110-wdt
> > > +      - starfive,jh8100-wdt
> > >  
> > >    reg:
> > >      maxItems: 1
> > > @@ -45,6 +46,7 @@ properties:
> > >        - const: core
> > >  
> > >    resets:
> > > +    minItems: 1
> > >      items:
> > >        - description: APB reset
> > >        - description: Core reset  
> > 
> > This relaxes the constraints for the existing devices, please add
> > per compatible constraints to avoid doing so.  
> 
Thanks Conor. Just to clarify, are you suggesting to add what was done
in v1?
v1:
https://lore.kernel.org/all/20231209142723.2060196-3-jisheng.teoh@starfivetech.com/

> Also, you do not appear to have implemented the request from Krzysztof
> to express compatibility with the jh7110.
> 
Ok, fix that up.
Conor Dooley Dec. 13, 2023, 4:35 p.m. UTC | #4 
On Wed, Dec 13, 2023 at 10:57:59AM +0800, Ji Sheng Teoh wrote:
> On Tue, 12 Dec 2023 16:47:59 +0000
> Conor Dooley <conor@kernel.org> wrote:
> 
> > On Tue, Dec 12, 2023 at 04:46:00PM +0000, Conor Dooley wrote:
> > > On Tue, Dec 12, 2023 at 11:17:31AM +0800, Ji Sheng Teoh wrote:  
> > > > Add "starfive,jh8100-wdt" compatible string for StarFive's JH8100
> > > > watchdog.
> > > > Since JH8100 watchdog only has 1 reset signal, update binding
> > > > document to support one reset for "starfive,jh8100-wdt"
> > > > compatible.
> > > > 
> > > > Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com>
> > > > Signed-off-by: Ji Sheng Teoh <jisheng.teoh@starfivetech.com>
> > > > ---
> > > >  .../devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > > | 2 ++ 1 file changed, 2 insertions(+)
> > > > 
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > > b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > > index 68f3f6fd08a6..02572b16ac08 100644 ---
> > > > a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > > +++
> > > > b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > > @@ -27,6 +27,7 @@ properties: enum:
> > > >        - starfive,jh7100-wdt
> > > >        - starfive,jh7110-wdt
> > > > +      - starfive,jh8100-wdt
> > > >  
> > > >    reg:
> > > >      maxItems: 1
> > > > @@ -45,6 +46,7 @@ properties:
> > > >        - const: core
> > > >  
> > > >    resets:
> > > > +    minItems: 1
> > > >      items:
> > > >        - description: APB reset
> > > >        - description: Core reset  
> > > 
> > > This relaxes the constraints for the existing devices, please add
> > > per compatible constraints to avoid doing so.  
> > 
> Thanks Conor. Just to clarify, are you suggesting to add what was done
> in v1?
> v1:
> https://lore.kernel.org/all/20231209142723.2060196-3-jisheng.teoh@starfivetech.com/

No, but similar. Add numerical constraints that vary per SoC without
changing the names of the resets on a per-SoC basis.:wq
Ji Sheng Teoh Dec. 14, 2023, 5:17 a.m. UTC | #5 
On Wed, 13 Dec 2023 16:35:39 +0000
Conor Dooley <conor@kernel.org> wrote:

> On Wed, Dec 13, 2023 at 10:57:59AM +0800, Ji Sheng Teoh wrote:
> > On Tue, 12 Dec 2023 16:47:59 +0000
> > Conor Dooley <conor@kernel.org> wrote:
> >   
> > > On Tue, Dec 12, 2023 at 04:46:00PM +0000, Conor Dooley wrote:  
> > > > On Tue, Dec 12, 2023 at 11:17:31AM +0800, Ji Sheng Teoh wrote:
> > > >   
> > > > > Add "starfive,jh8100-wdt" compatible string for StarFive's
> > > > > JH8100 watchdog.
> > > > > Since JH8100 watchdog only has 1 reset signal, update binding
> > > > > document to support one reset for "starfive,jh8100-wdt"
> > > > > compatible.
> > > > > 
> > > > > Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com>
> > > > > Signed-off-by: Ji Sheng Teoh <jisheng.teoh@starfivetech.com>
> > > > > ---
> > > > >  .../devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > > > | 2 ++ 1 file changed, 2 insertions(+)
> > > > > 
> > > > > diff --git
> > > > > a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > > > b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > > > index 68f3f6fd08a6..02572b16ac08 100644 ---
> > > > > a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > > > +++
> > > > > b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > > > @@ -27,6 +27,7 @@ properties: enum:
> > > > >        - starfive,jh7100-wdt
> > > > >        - starfive,jh7110-wdt
> > > > > +      - starfive,jh8100-wdt
> > > > >  
> > > > >    reg:
> > > > >      maxItems: 1
> > > > > @@ -45,6 +46,7 @@ properties:
> > > > >        - const: core
> > > > >  
> > > > >    resets:
> > > > > +    minItems: 1
> > > > >      items:
> > > > >        - description: APB reset
> > > > >        - description: Core reset    
> > > > 
> > > > This relaxes the constraints for the existing devices, please
> > > > add per compatible constraints to avoid doing so.    
> > >   
> > Thanks Conor. Just to clarify, are you suggesting to add what was
> > done in v1?
> > v1:
> > https://lore.kernel.org/all/20231209142723.2060196-3-jisheng.teoh@starfivetech.com/
> >  
> 
> No, but similar. Add numerical constraints that vary per SoC without
> changing the names of the resets on a per-SoC basis.:wq
> 
Sent out v3, hope it addresses the comments.
v3:
https://lore.kernel.org/all/20231214033056.3953143-2-jisheng.teoh@starfivetech.com/
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
index 68f3f6fd08a6..02572b16ac08 100644
--- a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
@@ -27,6 +27,7 @@  properties:
     enum:
       - starfive,jh7100-wdt
       - starfive,jh7110-wdt
+      - starfive,jh8100-wdt
 
   reg:
     maxItems: 1
@@ -45,6 +46,7 @@  properties:
       - const: core
 
   resets:
+    minItems: 1
     items:
       - description: APB reset
       - description: Core reset