mbox series

[v4,0/1] Stabilize use of vblank_refcount

Message ID 20231212231101.9240-1-quic_parellan@quicinc.com (mailing list archive)
Headers show
Series Stabilize use of vblank_refcount | expand

Message

Paloma Arellano Dec. 12, 2023, 11:10 p.m. UTC
There is currently a race condition occuring when accessing
vblank_refcount. Therefore, vblank irq timeouts may occur.

Avoid any vblank irq timeouts by stablizing the use of vblank_refcount.

Changes from prior versions:
   v4: - Removed vblank_ctl_lock from dpu_encoder_virt, so it is only a
         parameter of dpu_encoder_phys.
       - Switch from atomic refcnt to a simple int counter as mutex has
         now been added
   v3: - Mistakenly did not change wording of patch #2 in last version.
         It is done now.
   v2: - Slightly changed wording of patch #2 commit message

Paloma Arellano (1):
  drm/msm/dpu: Add mutex lock in control vblank irq

 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c   |  1 -
 .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h  |  4 ++-
 .../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c  | 32 ++++++++++++------
 .../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c  | 33 ++++++++++++-------
 4 files changed, 47 insertions(+), 23 deletions(-)

Comments

Dmitry Baryshkov Dec. 13, 2023, 12:37 a.m. UTC | #1
On Tue, 12 Dec 2023 15:10:57 -0800, Paloma Arellano wrote:
> There is currently a race condition occuring when accessing
> vblank_refcount. Therefore, vblank irq timeouts may occur.
> 
> Avoid any vblank irq timeouts by stablizing the use of vblank_refcount.
> 
> Changes from prior versions:
>    v4: - Removed vblank_ctl_lock from dpu_encoder_virt, so it is only a
>          parameter of dpu_encoder_phys.
>        - Switch from atomic refcnt to a simple int counter as mutex has
>          now been added
>    v3: - Mistakenly did not change wording of patch #2 in last version.
>          It is done now.
>    v2: - Slightly changed wording of patch #2 commit message
> 
> [...]

Applied, thanks!

[1/1] drm/msm/dpu: Add mutex lock in control vblank irq
      https://gitlab.freedesktop.org/lumag/msm/-/commit/b9dc09b4e534

Best regards,