diff mbox series

[2/4] watchdog: it87_wdt: Remove redundant max_units setting

Message ID 20231213094525.11849-2-devlists@wefi.net (mailing list archive)
State New
Headers show
Series [1/4] watchdog: it87_wdt: add blank line after variable declaration | expand

Commit Message

Werner Fischer Dec. 13, 2023, 9:45 a.m. UTC
Commit 893dc8b5c978 ("watchdog: it87: Drop support for resetting watchdog
though CIR and Game port") removed the try_gameport variable, and left
max_units setting redundant.

To clean up the code, this patch removes this redundant setting.

Signed-off-by: Werner Fischer <devlists@wefi.net>
---
 drivers/watchdog/it87_wdt.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Guenter Roeck Dec. 13, 2023, 2:54 p.m. UTC | #1
On Wed, Dec 13, 2023 at 10:45:23AM +0100, Werner Fischer wrote:
> Commit 893dc8b5c978 ("watchdog: it87: Drop support for resetting watchdog
> though CIR and Game port") removed the try_gameport variable, and left
> max_units setting redundant.
> 
> To clean up the code, this patch removes this redundant setting.
> 
> Signed-off-by: Werner Fischer <devlists@wefi.net>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/watchdog/it87_wdt.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/watchdog/it87_wdt.c b/drivers/watchdog/it87_wdt.c
> index 6b7f7ec03633..ca377096bdd7 100644
> --- a/drivers/watchdog/it87_wdt.c
> +++ b/drivers/watchdog/it87_wdt.c
> @@ -274,10 +274,6 @@ static int __init it87_wdt_init(void)
>  	case IT8712_ID:
>  		max_units = (chip_rev < 8) ? 255 : 65535;
>  		break;
> -	case IT8716_ID:
> -	case IT8726_ID:
> -		max_units = 65535;
> -		break;
>  	case IT8607_ID:
>  	case IT8613_ID:
>  	case IT8620_ID:
> @@ -287,9 +283,11 @@ static int __init it87_wdt_init(void)
>  	case IT8655_ID:
>  	case IT8665_ID:
>  	case IT8686_ID:
> +	case IT8716_ID:
>  	case IT8718_ID:
>  	case IT8720_ID:
>  	case IT8721_ID:
> +	case IT8726_ID:
>  	case IT8728_ID:
>  	case IT8772_ID:
>  	case IT8783_ID:
> -- 
> 2.39.2
> 
>
diff mbox series

Patch

diff --git a/drivers/watchdog/it87_wdt.c b/drivers/watchdog/it87_wdt.c
index 6b7f7ec03633..ca377096bdd7 100644
--- a/drivers/watchdog/it87_wdt.c
+++ b/drivers/watchdog/it87_wdt.c
@@ -274,10 +274,6 @@  static int __init it87_wdt_init(void)
 	case IT8712_ID:
 		max_units = (chip_rev < 8) ? 255 : 65535;
 		break;
-	case IT8716_ID:
-	case IT8726_ID:
-		max_units = 65535;
-		break;
 	case IT8607_ID:
 	case IT8613_ID:
 	case IT8620_ID:
@@ -287,9 +283,11 @@  static int __init it87_wdt_init(void)
 	case IT8655_ID:
 	case IT8665_ID:
 	case IT8686_ID:
+	case IT8716_ID:
 	case IT8718_ID:
 	case IT8720_ID:
 	case IT8721_ID:
+	case IT8726_ID:
 	case IT8728_ID:
 	case IT8772_ID:
 	case IT8783_ID: