[v2] ASoC: mediatek: mt7986: silence error in case of -EPROBE_DEFER

Commit Message

Daniel Golle Dec. 12, 2023, 11:10 p.m. UTC

If probe is defered no error should be printed. Use dev_err_probe() to
have it muted.

Signed-off-by: Daniel Golle <[e-mail]>
Reviewed-by: Maso Huang <[e-mail]>
---
v2: use dev_err_probe()

 sound/soc/mediatek/mt7986/mt7986-wm8960.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

AngeloGioacchino Del Regno Dec. 13, 2023, 10:35 a.m. UTC | #1

Il 13/12/23 00:10, Daniel Golle ha scritto:
> If probe is defered no error should be printed. Use dev_err_probe() to
> have it muted.
> 
> Signed-off-by: Daniel Golle <[e-mail]>
> Reviewed-by: Maso Huang <[e-mail]>

Reviewed-by: AngeloGioacchino Del Regno <[e-mail]>

Mark Brown Dec. 13, 2023, 7:23 p.m. UTC | #2

On Tue, 12 Dec 2023 23:10:07 +0000, Daniel Golle wrote:
> If probe is defered no error should be printed. Use dev_err_probe() to
> have it muted.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: mediatek: mt7986: silence error in case of -EPROBE_DEFER
      commit: 6475b8e1821c9d14e60592a74c10d75431500c7c

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Patch

diff --git a/sound/soc/mediatek/mt7986/mt7986-wm8960.c b/sound/soc/mediatek/mt7986/mt7986-wm8960.c
index c1390b3734101..6982e833421d6 100644
--- a/sound/soc/mediatek/mt7986/mt7986-wm8960.c
+++ b/sound/soc/mediatek/mt7986/mt7986-wm8960.c
@@ -144,7 +144,7 @@  static int mt7986_wm8960_machine_probe(struct platform_device *pdev)
 
 	ret = devm_snd_soc_register_card(&pdev->dev, card);
 	if (ret) {
-		dev_err(&pdev->dev, "%s snd_soc_register_card fail: %d\n", __func__, ret);
+		dev_err_probe(&pdev->dev, ret, "%s snd_soc_register_card fail\n", __func__);
 		goto err_of_node_put;
 	}