[0/2] btrfs: migrate the remaining functions exposed by a full fstests with larger metadata folios

Message

Qu Wenruo Dec. 12, 2023, 5:24 a.m. UTC

[REPO]
This patchset along with all the previous migrations (and the final
enablement patch) can be found here:

https://github.com/adam900710/linux/tree/eb_memory

With all the previous migrations (although only tested without larger
folios), we are finally just one step away from enabling larger folio
support for btrfs metadata.

During my local full fstests runs with larger metadata folios, there are
only two bugs hit, all related to some code path not yet handling folios
correct:

- eb_bitmap_offset()
- btrfs_repair_eb_io_failure()

Otherwise my local branch can already pass local fstests without new
regressions.

So here is the final (and I hope is the last) migrations for involed
metadata code path, before the final patch enabling larger folio
support.

Qu Wenruo (2):
  btrfs: migrate eb_bitmap_offset() to folio interfaces
  btrfs: migrate btrfs_repair_io_failure() to folio interfaces

 fs/btrfs/bio.c       | 15 +++++++++++----
 fs/btrfs/bio.h       |  4 ++--
 fs/btrfs/disk-io.c   | 13 +++++++------
 fs/btrfs/extent_io.c | 22 ++++++++++------------
 4 files changed, 30 insertions(+), 24 deletions(-)

Comments

David Sterba Dec. 13, 2023, 10:39 p.m. UTC | #1

On Tue, Dec 12, 2023 at 03:54:08PM +1030, Qu Wenruo wrote:
> [REPO]
> This patchset along with all the previous migrations (and the final
> enablement patch) can be found here:
> 
> https://github.com/adam900710/linux/tree/eb_memory
> 
> With all the previous migrations (although only tested without larger
> folios), we are finally just one step away from enabling larger folio
> support for btrfs metadata.
> 
> During my local full fstests runs with larger metadata folios, there are
> only two bugs hit, all related to some code path not yet handling folios
> correct:
> 
> - eb_bitmap_offset()
> - btrfs_repair_eb_io_failure()
> 
> Otherwise my local branch can already pass local fstests without new
> regressions.
> 
> So here is the final (and I hope is the last) migrations for involed
> metadata code path, before the final patch enabling larger folio
> support.

Great, thanks. We'll need to test the first batch of folio conversion
but so far it seems it's ok, enabling the higher order folios can be
done at rc3 time in case we want to target the next major release, or we
can postpone it to the following one if needed.