| Message ID | 20231216194321.18928-2-ericwouds@gmail.com (mailing list archive) |
|---|---|
| State | RFC |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Add en8811h phy driver and devicetree binding doc | expand |
On Sat, Dec 16, 2023 at 08:43:17PM +0100, Eric Woudstra wrote: > The en8811h phy can be set with serdes polarity reversed on rx and/or tx. > > Signed-off-by: Eric Woudstra <ericwouds@gmail.com> > --- > .../bindings/net/airoha,en8811h.yaml | 42 +++++++++++++++++++ > 1 file changed, 42 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/airoha,en8811h.yaml > > diff --git a/Documentation/devicetree/bindings/net/airoha,en8811h.yaml b/Documentation/devicetree/bindings/net/airoha,en8811h.yaml > new file mode 100644 > index 000000000000..96febd8ed6fa > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/airoha,en8811h.yaml > @@ -0,0 +1,42 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/airoha,en8811h.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Airoha EN8811H PHY > + > +maintainers: > + - Someone <someone@somemail.com> > + > +description: > + Bindings for Airoha EN8811H PHY > + > +allOf: > + - $ref: ethernet-phy.yaml# > + > +properties: > + airoha,rx-pol-reverse: > + type: boolean > + description: > + Reverse rx polarity of SERDES. > + > + > + airoha,tx-pol-reverse: > + type: boolean > + description: > + Reverse tx polarity of SERDES. Is this to deal with wiring up the SERDES backwards? Is there a more detailed description in the data sheet? Andrew
> > Is this to deal with wiring up the SERDES backwards? Is there a more > detailed description in the data sheet? > Sadly, I have not received the datasheet. All comes from studying different versions of the driver. On the BananiPi-R3 Mini the RX pair is reversed: phy14: ethernet-phy@14 { reg = <14>; interrupts-extended = <&pio 48 IRQ_TYPE_EDGE_FALLING>; reset-gpios = <&pio 49 GPIO_ACTIVE_LOW>; reset-assert-us = <10000>; reset-deassert-us = <20000>; phy-mode = "2500base-x"; full-duplex; pause; airoha,rx-pol-reverse; leds { #address-cells = <1>; #size-cells = <0>; led@0 { /* en8811_a_gpio5 */ reg = <0>; color = <LED_COLOR_ID_YELLOW>; function = LED_FUNCTION_LAN; function-enumerator = <1>; default-state = "keep"; linux,default-trigger = "netdev"; }; led@1 { /* en8811_a_gpio4 */ reg = <1>; color = <LED_COLOR_ID_GREEN>; function = LED_FUNCTION_LAN; function-enumerator = <2>; default-state = "keep"; linux,default-trigger = "netdev"; }; }; };
On 16/12/2023 20:43, Eric Woudstra wrote: > The en8811h phy can be set with serdes polarity reversed on rx and/or tx. > > Signed-off-by: Eric Woudstra <ericwouds@gmail.com> > --- Why duplicated patchsets? Nothing improved here. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/airoha,en8811h.yaml b/Documentation/devicetree/bindings/net/airoha,en8811h.yaml new file mode 100644 index 000000000000..96febd8ed6fa --- /dev/null +++ b/Documentation/devicetree/bindings/net/airoha,en8811h.yaml @@ -0,0 +1,42 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/airoha,en8811h.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Airoha EN8811H PHY + +maintainers: + - Someone <someone@somemail.com> + +description: + Bindings for Airoha EN8811H PHY + +allOf: + - $ref: ethernet-phy.yaml# + +properties: + airoha,rx-pol-reverse: + type: boolean + description: + Reverse rx polarity of SERDES. + + + airoha,tx-pol-reverse: + type: boolean + description: + Reverse tx polarity of SERDES. + +unevaluatedProperties: false + +examples: + - | + mdio { + #address-cells = <1>; + #size-cells = <0>; + + ethphy1: ethernet-phy@1 { + reg = <1>; + airoha,rx-pol-reverse; + }; + };
The en8811h phy can be set with serdes polarity reversed on rx and/or tx. Signed-off-by: Eric Woudstra <ericwouds@gmail.com> --- .../bindings/net/airoha,en8811h.yaml | 42 +++++++++++++++++++ 1 file changed, 42 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/airoha,en8811h.yaml