| Message ID | 20231219141930.367426-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/amd/display: remove redundant initialization of variable remainder | expand |
Applied. Thanks! On Tue, Dec 19, 2023 at 12:40 PM Colin Ian King <colin.i.king@gmail.com> wrote: > > Variable remainder is being initialized with a value that is never read, > the assignment is redundant and can be removed. Also add a newline > after the declaration to clean up the coding style. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > drivers/gpu/drm/amd/display/dc/basics/conversion.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/basics/conversion.c b/drivers/gpu/drm/amd/display/dc/basics/conversion.c > index e295a839ab47..1090d235086a 100644 > --- a/drivers/gpu/drm/amd/display/dc/basics/conversion.c > +++ b/drivers/gpu/drm/amd/display/dc/basics/conversion.c > @@ -103,7 +103,8 @@ void convert_float_matrix( > > static uint32_t find_gcd(uint32_t a, uint32_t b) > { > - uint32_t remainder = 0; > + uint32_t remainder; > + > while (b != 0) { > remainder = a % b; > a = b; > -- > 2.39.2 >
diff --git a/drivers/gpu/drm/amd/display/dc/basics/conversion.c b/drivers/gpu/drm/amd/display/dc/basics/conversion.c index e295a839ab47..1090d235086a 100644 --- a/drivers/gpu/drm/amd/display/dc/basics/conversion.c +++ b/drivers/gpu/drm/amd/display/dc/basics/conversion.c @@ -103,7 +103,8 @@ void convert_float_matrix( static uint32_t find_gcd(uint32_t a, uint32_t b) { - uint32_t remainder = 0; + uint32_t remainder; + while (b != 0) { remainder = a % b; a = b;
Variable remainder is being initialized with a value that is never read, the assignment is redundant and can be removed. Also add a newline after the declaration to clean up the coding style. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/gpu/drm/amd/display/dc/basics/conversion.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)