| Message ID | 20231219090248.3317500-1-alexander.stein@ew.tq-group.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/1] phy: freescale: phy-fsl-imx8-mipi-dphy: Fix alias name to use dashes | expand |
On Tue, Dec 19, 2023 at 10:02:48AM +0100, Alexander Stein wrote: > Devicetree spec lists only dashes as valid characters for alias names. > Table 3.2: Valid characters for alias names, Devicee Specification, > Release v0.4 > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c > index e625b32889bf..0928a526e2ab 100644 > --- a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c > +++ b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c > @@ -706,7 +706,7 @@ static int mixel_dphy_probe(struct platform_device *pdev) > return ret; > } > > - priv->id = of_alias_get_id(np, "mipi_dphy"); > + priv->id = of_alias_get_id(np, "mipi-dphy"); Are there any in tree DT blobs using mipi_dphy which are going to break because of this change? Andrew
Hi Andrew, Am Dienstag, 19. Dezember 2023, 10:09:24 CET schrieb Andrew Lunn: > On Tue, Dec 19, 2023 at 10:02:48AM +0100, Alexander Stein wrote: > > Devicetree spec lists only dashes as valid characters for alias names. > > Table 3.2: Valid characters for alias names, Devicee Specification, > > Release v0.4 > > > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > --- > > > > drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c > > b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c index > > e625b32889bf..0928a526e2ab 100644 > > --- a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c > > +++ b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c > > @@ -706,7 +706,7 @@ static int mixel_dphy_probe(struct platform_device > > *pdev)> > > return ret; > > > > } > > > > - priv->id = of_alias_get_id(np, "mipi_dphy"); > > + priv->id = of_alias_get_id(np, "mipi-dphy"); > > Are there any in tree DT blobs using mipi_dphy which are going to > break because of this change? You are right, I should have mentioned that already. The alias is only used when used on a combo-PHY, which is only i.MX8QXP. Up until now there is no DT node in-kernel which uses the fsl,imx8qxp-mipi-dphy compatible. So no there should be no blobs at all using the old alias name. Best regards, Alexander
On Tue, Dec 19, 2023 at 10:13:03AM +0100, Alexander Stein wrote: > Hi Andrew, > > Am Dienstag, 19. Dezember 2023, 10:09:24 CET schrieb Andrew Lunn: > > On Tue, Dec 19, 2023 at 10:02:48AM +0100, Alexander Stein wrote: > > > Devicetree spec lists only dashes as valid characters for alias names. > > > Table 3.2: Valid characters for alias names, Devicee Specification, > > > Release v0.4 > > > > > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > > --- > > > > > > drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c > > > b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c index > > > e625b32889bf..0928a526e2ab 100644 > > > --- a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c > > > +++ b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c > > > @@ -706,7 +706,7 @@ static int mixel_dphy_probe(struct platform_device > > > *pdev)> > > > return ret; > > > > > > } > > > > > > - priv->id = of_alias_get_id(np, "mipi_dphy"); > > > + priv->id = of_alias_get_id(np, "mipi-dphy"); > > > > Are there any in tree DT blobs using mipi_dphy which are going to > > break because of this change? > > You are right, I should have mentioned that already. > The alias is only used when used on a combo-PHY, which is only i.MX8QXP. Up > until now there is no DT node in-kernel which uses the fsl,imx8qxp-mipi-dphy > compatible. So no there should be no blobs at all using the old alias name. > > Best regards, > Alexander This seems correct. The NXP kernels have this revert commit which reinforces the fact that this driver does not probe on the "fsl,imx8qxp-mipi-dphy" compatible string even downstream. https://github.com/nxp-imx/linux-imx/commit/daf4e70d081a2672ac4a22ff39f6712798a0cc3b Adding Liu Ying.
On Tuesday, December 19, 2023 5:03 PM, Alexander Stein <alexander.stein@ew.tq-group.com> wrote: > Devicetree spec lists only dashes as valid characters for alias names. This saying is not accurate because it lists digit, lowercase letter and dash characters. > Table 3.2: Valid characters for alias names, Devicee Specification, > Release v0.4 > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> It makes sense to add a Fixes tag: Fixes: 3fbae284887d ("phy: freescale: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support") Regards, Liu Ying
diff --git a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c index e625b32889bf..0928a526e2ab 100644 --- a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c +++ b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c @@ -706,7 +706,7 @@ static int mixel_dphy_probe(struct platform_device *pdev) return ret; } - priv->id = of_alias_get_id(np, "mipi_dphy"); + priv->id = of_alias_get_id(np, "mipi-dphy"); if (priv->id < 0) { dev_err(dev, "Failed to get phy node alias id: %d\n", priv->id);
Devicetree spec lists only dashes as valid characters for alias names. Table 3.2: Valid characters for alias names, Devicee Specification, Release v0.4 Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)