| Message ID | 20231211140732.11475-6-bpoirier@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 58c8a08175586d325368d4c483a8b755ace7dfaa |
| Delegated to: | Stephen Hemminger |
| Headers | show |
| Series | bridge: vni: UI fixes | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Mon, 11 Dec 2023 09:07:17 -0500 Benjamin Poirier <bpoirier@nvidia.com> wrote: > Add the missing 'vni' subcommand to the top level `bridge help`. > For `bridge vni { add | del } ...`, 'dev' is a mandatory argument. > For `bridge vni show`, 'dev' is an optional argument. > > Fixes: 45cd32f9f7d5 ("bridge: vxlan device vnifilter support") > Reviewed-by: Petr Machata <petrm@nvidia.com> > Tested-by: Petr Machata <petrm@nvidia.com> > Signed-off-by: Benjamin Poirier <bpoirier@nvidia.com> > --- Acked-by: Stephen Hemminger <stephen@networkplumber.org>
diff --git a/bridge/bridge.c b/bridge/bridge.c index 339101a8..f4805092 100644 --- a/bridge/bridge.c +++ b/bridge/bridge.c @@ -36,7 +36,7 @@ static void usage(void) fprintf(stderr, "Usage: bridge [ OPTIONS ] OBJECT { COMMAND | help }\n" " bridge [ -force ] -batch filename\n" -"where OBJECT := { link | fdb | mdb | vlan | monitor }\n" +"where OBJECT := { link | fdb | mdb | vlan | vni | monitor }\n" " OPTIONS := { -V[ersion] | -s[tatistics] | -d[etails] |\n" " -o[neline] | -t[imestamp] | -n[etns] name |\n" " -c[ompressvlans] -color -p[retty] -j[son] }\n"); diff --git a/bridge/vni.c b/bridge/vni.c index ecd4c2b5..74668156 100644 --- a/bridge/vni.c +++ b/bridge/vni.c @@ -33,8 +33,8 @@ static void usage(void) fprintf(stderr, "Usage: bridge vni { add | del } vni VNI\n" " [ { group | remote } IP_ADDRESS ]\n" - " [ dev DEV ]\n" - " bridge vni { show }\n" + " dev DEV\n" + " bridge vni { show } [ dev DEV ]\n" "\n" "Where: VNI := 0-16777215\n" );
Add the missing 'vni' subcommand to the top level `bridge help`. For `bridge vni { add | del } ...`, 'dev' is a mandatory argument. For `bridge vni show`, 'dev' is an optional argument. Fixes: 45cd32f9f7d5 ("bridge: vxlan device vnifilter support") Reviewed-by: Petr Machata <petrm@nvidia.com> Tested-by: Petr Machata <petrm@nvidia.com> Signed-off-by: Benjamin Poirier <bpoirier@nvidia.com> --- bridge/bridge.c | 2 +- bridge/vni.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)