diff mbox series

[net-next,v2,1/7] net: dsa: realtek: drop cleanup from realtek_ops

Message ID 20231220042632.26825-2-luizluca@gmail.com (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series net: dsa: realtek: variants to drivers, interfaces to a common module | expand

Checks

Context Check Description
netdev/series_format success Posting correctly formatted
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 1115 this patch: 1115
netdev/cc_maintainers success CCed 9 of 9 maintainers
netdev/build_clang fail Errors and warnings before: 12 this patch: 12
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 1142 this patch: 1142
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Luiz Angelo Daros de Luca Dec. 20, 2023, 4:24 a.m. UTC 
It was never used and never referenced.

Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>
---
 drivers/net/dsa/realtek/realtek.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Alvin Šipraga Dec. 20, 2023, 1:57 p.m. UTC | #1 
On Wed, Dec 20, 2023 at 01:24:24AM -0300, Luiz Angelo Daros de Luca wrote:
> It was never used and never referenced.
> 
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
> Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>

You should always put your Signed-off-by last when sending patches.

> ---
>  drivers/net/dsa/realtek/realtek.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/dsa/realtek/realtek.h b/drivers/net/dsa/realtek/realtek.h
> index 790488e9c667..e9ee778665b2 100644
> --- a/drivers/net/dsa/realtek/realtek.h
> +++ b/drivers/net/dsa/realtek/realtek.h
> @@ -91,7 +91,6 @@ struct realtek_ops {
>  	int	(*detect)(struct realtek_priv *priv);
>  	int	(*reset_chip)(struct realtek_priv *priv);
>  	int	(*setup)(struct realtek_priv *priv);
> -	void	(*cleanup)(struct realtek_priv *priv);
>  	int	(*get_mib_counter)(struct realtek_priv *priv,
>  				   int port,
>  				   struct rtl8366_mib_counter *mib,
> -- 
> 2.43.0
>
Vladimir Oltean Dec. 21, 2023, 5:04 p.m. UTC | #2 
On Wed, Dec 20, 2023 at 01:57:41PM +0000, Alvin Šipraga wrote:
> On Wed, Dec 20, 2023 at 01:24:24AM -0300, Luiz Angelo Daros de Luca wrote:
> > It was never used and never referenced.
> > 
> > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
> > Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>
> 
> You should always put your Signed-off-by last when sending patches.

I'm not so sure about that.

When you send a patch, it gets reviewed and then accepted all in the
same version, the Reviewed-by tag will be after your sign off. It makes
more sense to me that if you send a patch with a review tag carried
over, you put it in the same place where it would sit if it was received
on the final patch version. Idk, not too big of a deal.
Alvin Šipraga Dec. 21, 2023, 8:05 p.m. UTC | #3 
On Thu, Dec 21, 2023 at 07:04:18PM +0200, Vladimir Oltean wrote:
> On Wed, Dec 20, 2023 at 01:57:41PM +0000, Alvin Šipraga wrote:
> > On Wed, Dec 20, 2023 at 01:24:24AM -0300, Luiz Angelo Daros de Luca wrote:
> > > It was never used and never referenced.
> > > 
> > > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
> > > Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>
> > 
> > You should always put your Signed-off-by last when sending patches.
> 
> I'm not so sure about that.
> 
> When you send a patch, it gets reviewed and then accepted all in the
> same version, the Reviewed-by tag will be after your sign off. It makes
> more sense to me that if you send a patch with a review tag carried
> over, you put it in the same place where it would sit if it was received
> on the final patch version. Idk, not too big of a deal.

It's what I see most of the time, and Andrew recently pointed out the
same [1]. Still there does not seem to be a consensus... [2] [3] [4]

But yea, not a big deal!

[1] https://lore.kernel.org/all/8d2dd95b-13f7-41d8-997f-d5c2953dcb06@lunn.ch/
[2] https://lore.kernel.org/all/20200408073603.GA948@gerhold.net/
[3] https://lore.kernel.org/all/20190627083443.4f4918a7@lwn.net/
[4] https://lore.kernel.org/all/87a7zzd47q.fsf@intel.com/
Luiz Angelo Daros de Luca Dec. 22, 2023, 10:32 p.m. UTC | #4 
> On Thu, Dec 21, 2023 at 07:04:18PM +0200, Vladimir Oltean wrote:
> > On Wed, Dec 20, 2023 at 01:57:41PM +0000, Alvin Šipraga wrote:
> > > On Wed, Dec 20, 2023 at 01:24:24AM -0300, Luiz Angelo Daros de Luca wrote:
> > > > It was never used and never referenced.
> > > >
> > > > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
> > > > Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>
> > >
> > > You should always put your Signed-off-by last when sending patches.
> >
> > I'm not so sure about that.
> >
> > When you send a patch, it gets reviewed and then accepted all in the
> > same version, the Reviewed-by tag will be after your sign off. It makes
> > more sense to me that if you send a patch with a review tag carried
> > over, you put it in the same place where it would sit if it was received
> > on the final patch version. Idk, not too big of a deal.
>
> It's what I see most of the time, and Andrew recently pointed out the
> same [1]. Still there does not seem to be a consensus... [2] [3] [4]
>
> But yea, not a big deal!
>
> [1] https://lore.kernel.org/all/8d2dd95b-13f7-41d8-997f-d5c2953dcb06@lunn.ch/
> [2] https://lore.kernel.org/all/20200408073603.GA948@gerhold.net/
> [3] https://lore.kernel.org/all/20190627083443.4f4918a7@lwn.net/
> [4] https://lore.kernel.org/all/87a7zzd47q.fsf@intel.com/

I'll keep the original sequence. Normally, the last Signed-off-by is
the one that merged it, not the author.

Regards,

Luiz
diff mbox series

Patch

diff --git a/drivers/net/dsa/realtek/realtek.h b/drivers/net/dsa/realtek/realtek.h
index 790488e9c667..e9ee778665b2 100644
--- a/drivers/net/dsa/realtek/realtek.h
+++ b/drivers/net/dsa/realtek/realtek.h
@@ -91,7 +91,6 @@  struct realtek_ops {
 	int	(*detect)(struct realtek_priv *priv);
 	int	(*reset_chip)(struct realtek_priv *priv);
 	int	(*setup)(struct realtek_priv *priv);
-	void	(*cleanup)(struct realtek_priv *priv);
 	int	(*get_mib_counter)(struct realtek_priv *priv,
 				   int port,
 				   struct rtl8366_mib_counter *mib,