| Message ID | 20231221022531.9772-1-hbh25y@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8fcb0382af6f1ef50936f1be05b8149eb2f88496 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2] net: sched: em_text: fix possible memory leak in em_text_destroy() | expand |
On Thu, Dec 21, 2023 at 10:25:31AM +0800, Hangyu Hua wrote: > m->data needs to be freed when em_text_destroy is called. > > Fixes: d675c989ed2d ("[PKT_SCHED]: Packet classification based on textsearch (ematch)") > Acked-by: Jamal Hadi Salim <jhs@mojatatu.com> > Signed-off-by: Hangyu Hua <hbh25y@gmail.com> Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Thu, 21 Dec 2023 10:25:31 +0800 you wrote: > m->data needs to be freed when em_text_destroy is called. > > Fixes: d675c989ed2d ("[PKT_SCHED]: Packet classification based on textsearch (ematch)") > Acked-by: Jamal Hadi Salim <jhs@mojatatu.com> > Signed-off-by: Hangyu Hua <hbh25y@gmail.com> > --- > > [...] Here is the summary with links: - [v2] net: sched: em_text: fix possible memory leak in em_text_destroy() https://git.kernel.org/netdev/net/c/8fcb0382af6f You are awesome, thank you!
diff --git a/net/sched/em_text.c b/net/sched/em_text.c index 6f3c1fb2fb44..f176afb70559 100644 --- a/net/sched/em_text.c +++ b/net/sched/em_text.c @@ -97,8 +97,10 @@ static int em_text_change(struct net *net, void *data, int len, static void em_text_destroy(struct tcf_ematch *m) { - if (EM_TEXT_PRIV(m) && EM_TEXT_PRIV(m)->config) + if (EM_TEXT_PRIV(m) && EM_TEXT_PRIV(m)->config) { textsearch_destroy(EM_TEXT_PRIV(m)->config); + kfree(EM_TEXT_PRIV(m)); + } } static int em_text_dump(struct sk_buff *skb, struct tcf_ematch *m)
m->data needs to be freed when em_text_destroy is called. Fixes: d675c989ed2d ("[PKT_SCHED]: Packet classification based on textsearch (ematch)") Acked-by: Jamal Hadi Salim <jhs@mojatatu.com> Signed-off-by: Hangyu Hua <hbh25y@gmail.com> --- v2: fix a type usage error net/sched/em_text.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)