mbox series

[v4,iwl-next,0/6] ice: fix timestamping in reset process

Message ID 20231221100326.1030761-1-karol.kolacinski@intel.com (mailing list archive)
Headers show
Series ice: fix timestamping in reset process | expand

Message

Karol Kolacinski Dec. 21, 2023, 10:03 a.m. UTC 
PTP reset process has multiple places where timestamping can end up in
an incorrect state.

This series introduces a proper state machine for PTP and refactors
a large part of the code to ensure that timestamping does not break.


Jacob Keller (5):
  ice: pass reset type to PTP reset functions
  ice: rename verify_cached to has_ready_bitmap
  ice: rename ice_ptp_tx_cfg_intr
  ice: factor out ice_ptp_rebuild_owner()
  ice: stop destroying and reinitalizing Tx tracker during reset

Karol Kolacinski (1):
  ice: introduce PTP state machine

V2 -> V3: rebased the series fixed Tx timestamps missing
V1 -> V2: rebased the series and dropped already merged patches

 drivers/net/ethernet/intel/ice/ice.h         |   1 -
 drivers/net/ethernet/intel/ice/ice_ethtool.c |   2 +-
 drivers/net/ethernet/intel/ice/ice_main.c    |   4 +-
 drivers/net/ethernet/intel/ice/ice_ptp.c     | 231 +++++++++++--------
 drivers/net/ethernet/intel/ice/ice_ptp.h     |  34 ++-
 5 files changed, 166 insertions(+), 106 deletions(-)


base-commit: 67b40ee196fd2fd6d9b7f9b58912587c837bdc39

Comments

Brett Creeley Dec. 21, 2023, 6:20 p.m. UTC | #1 
On 12/21/2023 2:03 AM, Karol Kolacinski wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> PTP reset process has multiple places where timestamping can end up in
> an incorrect state.
> 
> This series introduces a proper state machine for PTP and refactors
> a large part of the code to ensure that timestamping does not break.
> 
> 
> Jacob Keller (5):
>    ice: pass reset type to PTP reset functions
>    ice: rename verify_cached to has_ready_bitmap
>    ice: rename ice_ptp_tx_cfg_intr
>    ice: factor out ice_ptp_rebuild_owner()
>    ice: stop destroying and reinitalizing Tx tracker during reset
> 
> Karol Kolacinski (1):
>    ice: introduce PTP state machine
> 
> V2 -> V3: rebased the series fixed Tx timestamps missing
> V1 -> V2: rebased the series and dropped already merged patches
> 
>   drivers/net/ethernet/intel/ice/ice.h         |   1 -
>   drivers/net/ethernet/intel/ice/ice_ethtool.c |   2 +-
>   drivers/net/ethernet/intel/ice/ice_main.c    |   4 +-
>   drivers/net/ethernet/intel/ice/ice_ptp.c     | 231 +++++++++++--------
>   drivers/net/ethernet/intel/ice/ice_ptp.h     |  34 ++-
>   5 files changed, 166 insertions(+), 106 deletions(-)

For the series:

Reviewed-by: Brett Creeley <brett.creeley@amd.com>
> 
> 
> base-commit: 67b40ee196fd2fd6d9b7f9b58912587c837bdc39
> --
> 2.40.1
> 
>