| Message ID | 20231213084619.811599-1-shinichiro.kawasaki@wdc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [blktests] block/007: skip hybrid polling tests when kernel does not support it | expand |
On Dec 13, 2023 / 17:46, Shin'ichiro Kawasaki wrote: > Since the kernel commit 54bdd67d0f88 ("blk-mq: remove hybrid polling"), > kernel does not support hybrid polling. The test case block/007 > specifies auto-hybrid and fixed-hybrid polling for testing. But it is > confusing and meaningless when kernel does not support it. Check if > kernel supports hybrid polling. If not, skip the hybrid polling tests. > > Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com> FYI, this patch has got applied.
diff --git a/tests/block/007 b/tests/block/007 index faa3780..3b68d0d 100755 --- a/tests/block/007 +++ b/tests/block/007 @@ -58,14 +58,18 @@ test_device() { run_fio_job 1 # switch to auto-hybrid polling, run job - FIO_PERF_PREFIX="auto hybrid poll " _test_dev_queue_set io_poll_delay 0 - run_fio_job 1 + if [[ $(_test_dev_queue_get io_poll_delay) == '0' ]]; then + FIO_PERF_PREFIX="auto hybrid poll " + run_fio_job 1 + fi # switch to explicit delay polling, run job - FIO_PERF_PREFIX="fixed hybrid poll " _test_dev_queue_set io_poll_delay 4 - run_fio_job 1 + if [[ $(_test_dev_queue_get io_poll_delay) == '4' ]]; then + FIO_PERF_PREFIX="fixed hybrid poll " + run_fio_job 1 + fi echo "Test complete" }
Since the kernel commit 54bdd67d0f88 ("blk-mq: remove hybrid polling"), kernel does not support hybrid polling. The test case block/007 specifies auto-hybrid and fixed-hybrid polling for testing. But it is confusing and meaningless when kernel does not support it. Check if kernel supports hybrid polling. If not, skip the hybrid polling tests. Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com> --- tests/block/007 | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)